Skip to content

Mohan Fix Dropdown Overlap with Taking Time Off Content on Large Screens#3605

Merged
one-community merged 1 commit intodevelopmentfrom
Mohan-dropdown-overlap-large-screens
Nov 12, 2025
Merged

Mohan Fix Dropdown Overlap with Taking Time Off Content on Large Screens#3605
one-community merged 1 commit intodevelopmentfrom
Mohan-dropdown-overlap-large-screens

Conversation

@smohansatyaram
Copy link
Copy Markdown
Contributor

@smohansatyaram smohansatyaram commented Jun 3, 2025

Description

image

Main changes explained:

  • Added CSS rules for the .multi-select-filter class to set proper z-index (20) and positioning.
  • Enhanced the styling with focus-within state to increase z-index (30) when the dropdown is active.
  • This ensures that the dropdown menus in Team Member Tasks appear above any overlapping content.
  • Fixed the TagsSearch test failures that were causing Husky pre-commit errors.
  • Updated test cases to properly handle the profilePic parameter in the addResources function.
  • This ensures both visual correctness of dropdowns and successful code commits.

How to test:

  1. check into current branch
  2. do npm install, and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. Log as admin user
  5. Navigate to Dashboard → Team Member Tasks → Dropdown Menus
  6. Verify that dropdown menus appear correctly on top of other content, particularly on large screens
  7. Test on both small screens (below 768px) and large screens to ensure proper behavior in both cases

Screenshots or videos of changes:

0706.2.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 3, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 84df925
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/68efb23389654c0008b8abef
😎 Deploy Preview https://deploy-preview-3605--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jul 20, 2025
Copy link
Copy Markdown
Contributor

@saikrishnaraoyadagiri saikrishnaraoyadagiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Reviewed the PR, working as expected, the dropdown is not overlapping with taking time off content on large screens and screens below 768px.
image
image
image
image
image

Copy link
Copy Markdown

@harika-majji harika-majji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this dropdown feature, working as expected.

The dropdown is not overlapped in large and small screens.

Screenshot 2025-07-21 at 5 26 40 PM Screenshot 2025-07-21 at 5 32 53 PM Screenshot 2025-07-21 at 5 32 22 PM

Copy link
Copy Markdown
Contributor

@sankargalla sankargalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the Task section and confirmed that the Team, Team Code, and Color drop downs no longer overlap the Task Details area. I verified this across various screen sizes including mobile and everything functions as expected.

PR 3605(1)

Copy link
Copy Markdown

@Naveen-Kumar-Reddy-27 Naveen-Kumar-Reddy-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified Team Member Tasks → Dropdown Menus display above overlapping content on both large screens and screens below 768px.

Confirmed proper behavior in dark and light modes.

Functionality works as expected; no UI overlap issues found.

PR 3605 PR 3605 small PR 3605 large

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@Aswin20010 Aswin20010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested the PR addressing the dropdown overlap and Husky test failures.
Verified that the .multi-select-filter dropdown menus now render above all overlapping content on both large and small screens.
Confirmed z-index behavior changes (20 → 30 on focus) and validated proper visual stacking in Team Member Tasks. All functionalities and test suites passed — approved the PR.
Screenshot 2025-10-17 at 11 44 06 AM
Screenshot 2025-10-17 at 11 44 30 AM

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 8c0fbd3 into development Nov 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants