Peterson implemented the 'No user found' message in the autocomplete#3855
Conversation
peterson337
added
the
do not review
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
peterson337
removed
the
do not review
|
Navigated to Other Links → Permissions Management → Manage User Permissions. Tested the autocomplete functionality by typing the name of a non-existent user. Verified that the message 'No user found' is correctly displayed, confirming expected behavior for empty search results. |
shashankm9
left a comment
shashankm9
left a comment
There was a problem hiding this comment.
I have tested this PR. 'No user found' is displayed in the autocomplete when typed unexciting user name in the Manage User Permissions search bar.
ShravyaKudlu
left a comment
ShravyaKudlu
left a comment
There was a problem hiding this comment.
Works well in light and dark and mode
Namitha7070
left a comment
Namitha7070
left a comment
There was a problem hiding this comment.
Verified that the message "No user found" is correctly displayed upon entering a non-existent user name.
Untitled.video.-.Made.with.Clipchamp.4.mp4
|
I navigated to Other Links → Permissions Management → Manage User Permissions and tested the autocomplete by entering a non-existent user name. The message "No user found" was displayed as expected, confirming correct behavior for empty search results.
|
sohailuddinsyed
left a comment
sohailuddinsyed
left a comment
There was a problem hiding this comment.
On typing in the name of a user that does not exist, the message 'No user found' is displayed in the autocomplete.
Naveen-Kumar-Reddy-27
left a comment
Naveen-Kumar-Reddy-27
left a comment
There was a problem hiding this comment.
Checked out branch, installed dependencies, cleared cache, and logged in as admin.
Navigated to Other Links → Permissions Management → Manage User Permissions.
Typed a non-existent username; verified "No user found" message appears in autocomplete.
Functionality works as expected.
|
This feature works as intended and the code is great https://www.loom.com/share/b4d9dc2972ae4f6aad5a02fc688922cc?sid=c30347d4-73bc-4e63-a902-380aebfedc10 |
|
Autocomplete displays 'No user found' when a user does not exist in the drop down in Permissions Management page. PR3855.mp4 |
…age-in-autocomplete-2
peterson337
dismissed stale reviews from beblicarl, sohailuddinsyed, and ShravyaKudlu
via
1cf6dcc
|
|
Thank you all, merging! |
11 participants
Description
On the Permission Management page, there is a modal called 'Manage User Permissions' that contains an input field with an autocomplete feature. As the user types in the input, the autocomplete displays user names that match the typed text. However, if the user enters a non-existent user name, no message is shown in the autocomplete. This PR was opened to add a message indicating that no user was found when this situation occurs.
Related PRS (if any):
None.
Main changes explained:
The UserPermissionsPopUp.jsx component has been modified to fix the bug.
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Before my fix
After my fix
Note:
None