Skip to content

Fatima expenditure chart to module css#3885

Merged
one-community merged 6 commits intodevelopmentfrom
Fatima-ExpenditureChart-to-module-css
Aug 31, 2025
Merged

Fatima expenditure chart to module css#3885
one-community merged 6 commits intodevelopmentfrom
Fatima-ExpenditureChart-to-module-css

Conversation

@favils
Copy link
Copy Markdown
Contributor

@favils favils commented Aug 13, 2025

Description

image

Related PRS (if any):

This frontend PR is related to the #3565 frontend PR which is related to 1417 backend pr

Main changes explained:

  • Rename ExpenditureChart.css to ExpenditureChart.module.css
  • Update import in ExpenditureChart.jsx:
    import styles from './ExpenditureChart.module.css'
  • Replace className="..." usage with className={styles...}

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to /bmdashboard/totalconstructionsummary
  6. Look for Expenditure chart under financials tracking
  7. Ensure no logic or functional changes are introduced w/ the update to module css

Screenshots or videos of changes:

Note:

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 13, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit b615f8f
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/68a9ff66616aff0008734bbb
😎 Deploy Preview https://deploy-preview-3885--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@sourabhbagde sourabhbagde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the Planned vs Actual Costs chart under Financials Tracking loads correctly. Both Project and Category filters are available and working, and the chart displays Actual vs Planned values without issues. No logic or functional changes introduced, only CSS/module updates.
Also working fine in dark mode.
PR 3885 good
PR 3885 dark

Copy link
Copy Markdown

@vivekchandrabs vivekchandrabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-08-29 at 9 32 57 PM

The logic works fine and is same as like in development branch.

vivekchandrabs
vivekchandrabs approved these changes Aug 30, 2025
Copy link
Copy Markdown
Contributor

@SudheeshTD SudheeshTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the financial chart, and the logic looks good. Works in both light and dark mode.
image
image

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 40346f2 into development Aug 31, 2025
8 checks passed
@munishpatel
Copy link
Copy Markdown

It works good in both the UI's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants