Amalesh - Fixed the issue with displaying the “Contributors Report” #3958
Amalesh - Fixed the issue with displaying the “Contributors Report” #3958one-community merged 2 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
one-community
added
the
High Priority - Please Review First
vishnu-ing
left a comment
vishnu-ing
left a comment
There was a problem hiding this comment.
I have reviewed the code changes and tested the functionality in local. Everything works good for the 4 buttons "Show/Hide Total Project Report", "Show/Hide Total People Report", "Show/Hide Total Team Report", "Show/Hide Total Contributor Report" buttons and the charts are displayed and hidden accordingly along with the filter values applied in light and dark modes.
Note: The UI ends up with no report on the right and aligned to left without coming back to the center when clicking "Hide Project Lost Time", "Hide Person Lost Time", "Hide TeamLost Time" as shown below in the screenshots. But the changes LGTM. Just noting for reference.
srushti2403
left a comment
srushti2403
left a comment
There was a problem hiding this comment.
Tested and verified that 'Show Contributors Report' button works.
aseemdeshmukh
left a comment
aseemdeshmukh
left a comment
There was a problem hiding this comment.
All 4 buttons mentioned are properly functioning and expected data is reflected. Checked in both light and dark mode.
akshith312
left a comment
akshith312
left a comment
There was a problem hiding this comment.
Logged in as admin user.
Navigated to Reports and checked the buttons.
All the checks satisfy and work as expected.
After refreshing and clicking show contributors report first.
sohamsharma08
left a comment
sohamsharma08
left a comment
There was a problem hiding this comment.
Tested the PR and verified the Reports page thoroughly. Everything works as expected. Screenshots are attached below:
ezreal2020
left a comment
ezreal2020
left a comment
There was a problem hiding this comment.
Verified and tested with the code changes that 'Show Contributors Report' button works.
SudheeshTD
left a comment
SudheeshTD
left a comment
There was a problem hiding this comment.
Contributors report is working as expected. Tested in both light and Dark theme and its working.
sourabhbagde
left a comment
sourabhbagde
left a comment
There was a problem hiding this comment.
Tested and working as expected both in light and dark mode.
vivekchandrabs
left a comment
vivekchandrabs
left a comment
There was a problem hiding this comment.
I tested this feature by logging in is admin and also verifying Show Contributors button.
It works fine in the light and dark mode.
It properly displays the value that is been returned by the API.
|
Thank you all, merging! |
Amalesh-A
removed
the
High Priority - Please Review First
11 participants
Description
Related PRS (if any):
This frontend PR is related to the development branch of the backend.
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
It.works.mp4