Skip to content

Sai Sandeep taking over for Kristin Replace Blank Cards in the Financials Section#3970

Merged
one-community merged 21 commits intodevelopmentfrom
kristin-fix-financial-cards
Apr 5, 2026
Merged

Sai Sandeep taking over for Kristin Replace Blank Cards in the Financials Section#3970
one-community merged 21 commits intodevelopmentfrom
kristin-fix-financial-cards

Conversation

@KH07
Copy link
Copy Markdown
Contributor

@KH07 KH07 commented Aug 27, 2025 •
edited by saisandeepkoritala
Loading

Description

Screenshot 2026-03-31 012152

Related PRS (if any):

None

Main changes explained:

  • Added four cards in the Financials section and populated relevant data into the cards
  • Added responsive view for all devices

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Reports → Total Construction Summary (http://localhost:5173/bmdashboard/totalconstructionsummary)
  6. verify the UI in different layouts

Screenshots or videos of changes:

Screenshot 2026-04-02 143321 Screenshot 2026-04-02 143306

Note:

The current development branch has four hard-coded blank cards PR3365.

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 27, 2025 •
edited
Loading

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit e2c08c6
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69d1da9efad596000849aa2a
😎 Deploy Preview https://deploy-preview-3970--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hemanthvenkat
Copy link
Copy Markdown

hemanthvenkat commented Aug 28, 2025

PR3970.mp4

UI is good, working as expected

JERRRRY
JERRRRY approved these changes Aug 30, 2025
View reviewed changes
Copy link
Copy Markdown

@JERRRRY JERRRRY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good under light and dark mode.
Screenshot 2025-08-30 at 1 47 26 PM
Screenshot 2025-08-30 at 1 48 32 PM

SudheeshTD
SudheeshTD previously approved these changes Aug 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@SudheeshTD SudheeshTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to test this PR successfully. I can see the cards displaying in light and dark modes.
image

image image

@AbhishekSrikanth
Copy link
Copy Markdown
Contributor

AbhishekSrikanth commented Sep 11, 2025

Tested the changes in the PR. The construction summary page looks good and responsive in both light and dark mode.

image

deep3072
deep3072 approved these changes Sep 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@deep3072 deep3072 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Financials Section UI looks good. Approve

Screenshot 2025-09-20 at 14 51 41 Screenshot 2025-09-20 at 14 51 58 Screenshot 2025-09-20 at 14 52 19

deep3072
deep3072 approved these changes Sep 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@deep3072 deep3072 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Financials Section UI looks good. Approve

Screenshot 2025-09-20 at 14 51 41 Screenshot 2025-09-20 at 14 51 58 Screenshot 2025-09-20 at 14 52 19

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Oct 3, 2025
Aswin20010
Aswin20010 previously approved these changes Oct 16, 2025
View reviewed changes
Copy link
Copy Markdown

@Aswin20010 Aswin20010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new Financials section cards under Reports → Total Construction Summary. Verified that all four cards display correctly with proper data alignment and responsive behavior across different screen sizes. Confirmed layout consistency in both light and dark modes. All functionalities work as expected — approving the PR.

Screenshot 2025-10-16 at 12 23 15 PM Screenshot 2025-10-16 at 12 23 44 PM

rohanrastogi311
rohanrastogi311 suggested changes Jan 10, 2026
View reviewed changes
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kristin,

Getting a launch error: Error: Cannot find module '@rollup/rollup-darwin-arm64'

Please let me know to re-review once you've had a look.

PR 3970 Screenshot

@KH07 KH07 dismissed stale reviews from Aswin20010 and SudheeshTD via 3a77500 January 12, 2026 07:37
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 17, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Anusha-Gali
Anusha-Gali previously approved these changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kristin,

I did review your PR locally and am able to view the blank cards in financials section in all responsive screen sized.
Screenshot 2026-01-19 at 7 54 29 PM
Screenshot 2026-01-19 at 7 54 36 PM
Screenshot 2026-01-19 at 7 54 48 PM

@one-community one-community changed the title Kristin Replace Blank Cards in the Financials Section Sai Sandeep taking over for Kristin Replace Blank Cards in the Financials Section Mar 31, 2026
@saisandeepkoritala saisandeepkoritala self-assigned this Apr 3, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 5, 2026

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rohanrastogi311
rohanrastogi311 approved these changes Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sai,

Well done with this implementation.

Image

@one-community
Copy link
Copy Markdown
Member

one-community commented Apr 5, 2026

Thank you all, merging!

@one-community one-community merged commit 059bbb1 into development Apr 5, 2026
10 checks passed
@one-community one-community mentioned this pull request Apr 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

8 more reviewers

@JERRRRY JERRRRY JERRRRY approved these changes

@AbhishekSrikanth AbhishekSrikanth AbhishekSrikanth approved these changes

@hemanthvenkat hemanthvenkat hemanthvenkat approved these changes

@deep3072 deep3072 deep3072 approved these changes

@rohanrastogi311 rohanrastogi311 rohanrastogi311 approved these changes

@SudheeshTD SudheeshTD SudheeshTD left review comments

@Aswin20010 Aswin20010 Aswin20010 left review comments

@Anusha-Gali Anusha-Gali Anusha-Gali left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@saisandeepkoritala saisandeepkoritala

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.