Meenashi application page category#4014
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
RitzzzZ2021
left a comment
There was a problem hiding this comment.
Thank you for the detailed testing guide. The search button and category filter work as expected in both light and dark modes. Clicking a job correctly redirects to its corresponding link.
Suggestions:
- When navigating to /collaboration or refreshing the page, an error appears for fetching positions. I tested the backend PR #1701 and it works fine. Could you look into this?
- When displaying summaries, the title is misaligned in light mode but aligns correctly in dark mode. Applying consistent alignment styles across both modes should resolve the issue.
- There’s no data in the positions filter, so I wasn’t able to test it. Could you provide some data for testing?
|
@RitzzzZ2021 - Thanks for your comments! I’ve fixed the alignment of Summaries. However, I couldn’t reproduce the empty list in Select from positions. Could you please retry on your side and let me know the status? |
Previously, the component returned two separate JSX blocks. Now, it returns a single block with a conditional to handle both cases.
- Add position dropdown - Update getJobs and getSummaries API to include position input - Fix dark mode display
- Updated button label to toggle between `showSummaries` and `hideSummaries` - Applied filter chips heading only after clicking "Go" (not while typing) - Refactored content into `renderContent` function for cleaner rendering - Fixed alignment and spacing issues - Removed unnecessary `showTooltip` logic - Changed jobAdsPerPage from 20 → 10 for clearer visibility
…n, and filter chips
5db252b to
c71e237
Compare
|
@RitzzzZ2021, @khan-zoha - Thank you for your comments. The issue occurred due to a problem during the merge with the development branch, which caused the Position list to be empty. I’ve fixed it now — could you please retest and share your feedback? |
MeronTeweldebrhan
left a comment
There was a problem hiding this comment.
PR Review Feedback
Testing Outcome
✅ Search bar is filtering data as expected.
✅ Dark mode toggle is working correctly.
✅ Categories filter is functioning as expected.
✅ Pagination is working, along with the show/hide summaries toggle.
✅ Click on the image icon of a job
✅ Responsive on different screen sizes
Requested Change
- Please review and fix the Select from position filter
|
@RitzzzZ2021 @khan-zoha @MeronTeweldebrhan Please try the following steps to ensure dependencies are in sync with the updated lockfile: |
|
Reviewed PR #4014
|
…obal/HighestGoodNetworkApp into meenashi-application-page-category
Aditya-gam
left a comment
There was a problem hiding this comment.
- Logged in as admin user and navigated to
/collaboration. - All the page elements are displayed correctly.
- Search using title correctly displays results and limits the number of ads to 10.
- Category and Position drop-downs work as intended and correctly add filters and display results accordingly.
- The show summaries button toggles summaries and shows all summaries on one page.
- The page is responsive for small screens
- Dark mode works correctly. One issue is that the search panel changes size, and the 'Show Summaries' button wraps to the next line.
TestVideo.mov
…obal/HighestGoodNetworkApp into meenashi-application-page-category
|
Thank you all, merging! |

















Description
Main Changes
How to Test
Setup
Switch to the current branch
Delete node_modules:
rm -rf node_modules
Run:
Clear site data/cache in your browser
Note: If the backend is not running, the page will display:
Login
Navigate
/collaborationVerify Page Elements
Test Search and Filters
jobDetailsLinkTest Show Summaries
Additional Checks
Related PRS (if any):
This frontend PR is related to the OneCommunityGlobal/HGNRest#1701 backend PR.
Screenshots or videos of changes:
Application.Page.Category.04Sep.mp4
Note: