Skip to content

Carlos - HGN Skills Non-doc Task: User Skills Module CSS and Dark Mode#4072

Open
sircarmart wants to merge 19 commits intodevelopmentfrom
carlos-hgn-form-user-skills-dark-mode
Open

Carlos - HGN Skills Non-doc Task: User Skills Module CSS and Dark Mode#4072
sircarmart wants to merge 19 commits intodevelopmentfrom
carlos-hgn-form-user-skills-dark-mode

Conversation

@sircarmart
Copy link
Contributor

Description

This pull request updates the HGN Skills form and the HGN Skills page to support dark mode and make some minor changes to finish transferring the CSS to module CSS in these folders. This was originally a small change for the HGNForm to have css converted into module CSS but the changes were small enough that support for dark mode was approved by Jae.

Related PRS (if any):

This frontend pr is not related to any backend pr. Use latest backend development branch.

Main changes explained:

  • Updates components in HGNSkillsDashboard/SkillsProfile to support Dark Mode styling.
  • Updates components in HGNForm/pages and HGNForm/questionpages to support Dark Mode styling
  • Renames/Updates HGNSkillsDashboard/SkillsProfile/styles/AdditionalInfo.css into HGNSkillsDashboard/SkillsProfile/styles/AdditionInfo.module.css

How to test:

  1. check into current branch
  2. do yarn install and yarn start:local to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to HGNForm
  6. Inspect pages while filling out form to ensure it is all supported in dark mode.
  7. After completing form proceed to HGN Profile Skills
  8. verify the profile skills page works in dark mode

Screenshots or videos of changes:

Skills Form Dark Mode
image

Skills Profile Dark Mode
image

@netlify
Copy link

netlify bot commented Sep 14, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 47c2f6c
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/68c609943f615b000814afb6
😎 Deploy Preview https://deploy-preview-4072--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@RitzzzZ2021 RitzzzZ2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The User Skills form works well in dark mode. Also checked the profile, looks good.

image image

Copy link
Contributor

@akshith312 akshith312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes. Pages work in the dark mode.

image image image

Copy link

@Swetha-1306 Swetha-1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR, the form can be seen in dark mode and I am able to submit it, However I am not able to see the profile page after submitting the form.
Screenshot 2025-09-19 at 11 12 40 PM
Screenshot 2025-09-19 at 11 14 01 PM
Screenshot 2025-09-19 at 11 27 11 PM
Screenshot 2025-09-19 at 11 27 32 PM

Copy link
Contributor

@KurtisIvey KurtisIvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and everything works as expected. Thanks for all your hard work. Approved!

Screenshot 2025-09-27 at 2 12 14 PM Screenshot 2025-09-27 at 2 10 49 PM Screenshot 2025-09-27 at 2 12 33 PM Screenshot 2025-09-27 at 2 09 12 PM

@beblicarl beblicarl self-requested a review October 23, 2025 10:53
@beblicarl
Copy link
Contributor

This functionality works as intended, and the code is great

image image

@Anusha-Gali Anusha-Gali added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 27, 2025
Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Carlos,

I reviewed your PR locally and can confirm that all form and profile functionality works as expected. However, I noticed two minor UI issues in dark mode. As shown below, the Next and Submit buttons appear in black, while the Back button displays in white. This creates an inconsistency in the button styling under dark mode.
Screenshot 2025-11-28 at 5 40 49 PM
Screenshot 2025-11-28 at 5 40 58 PM

Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Carlos,

I'm unable to get past the first page on the form. The name keeps going back to undefined undefined too.

Please have a look and let me know to re-review.

PR 4072 Screenshot

@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants