Skip to content

Siva - Fix Dates and Online Filters” Misalignment#4388

Merged
one-community merged 17 commits intodevelopmentfrom
siva/fix-filter-alignment-figma-match-clean
Apr 12, 2026
Merged

Siva - Fix Dates and Online Filters” Misalignment#4388
one-community merged 17 commits intodevelopmentfrom
siva/fix-filter-alignment-figma-match-clean

Conversation

@pavanputti
Copy link
Copy Markdown
Contributor

@pavanputti pavanputti commented Nov 14, 2025

Description

Screenshot 2025-11-16 at 1 33 32 AM Screenshot 2025-11-16 at 1 34 33 AM

Related PRS (if any):

This frontend PR is related to the development backend PR. To test this frontend PR, you need to checkout the development backend PR.

Main changes explained:

  • Delete file A for removing unused components …
  • Update file B for including new pattern …
  • Create file C for introducing new components …

How to test:

  1. Check out branch: siva/fix-filter-alignment-figma-match-clean
  2. Run npm install (if needed)
  3. Start the development server
  4. Navigate to: /communityportal/
  5. Open the Search Filters panel on the left sidebar
  6. Verify:
  • "Dates" label is properly aligned
  • "Tomorrow" and "This Weekend" radio buttons are aligned with consistent indentation
  • "Online" label is properly aligned
  • "Online Only" checkbox is aligned with consistent indentation
  • All filter elements match the Figma design spacing and alignment

Screenshots or videos of changes:

Screenshot 2025-11-16 at 1 24 46 AM

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 14, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit c82b93d
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69daf329908d0a00089aa7b4
😎 Deploy Preview https://deploy-preview-4388--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pavanputti pavanputti added DO NOT MERGE Don't merge PR do not review Do not review or look at code without full context and removed DO NOT MERGE Don't merge PR labels Nov 14, 2025
- Added CSS variables for font sizes and line heights
- Standardized typography across filter labels and options
- Improved visual hierarchy with consistent font sizing
- Enhanced spacing alignment with refined margin-top values
- Applied consistent letter-spacing and line-height for better readability
- Updated date input to use CSS module class for consistent styling
- Added hover states for all interactive filter elements
- Enhanced visual feedback with accent-color for radio/checkbox inputs
- Added box-sizing border-box for consistent sizing
- Improved label hover states for better user experience
- Ensured all filter inputs have consistent styling and behavior
- Replaced form labels with divs for section headers (Dates, Online)
- Improved vertical alignment of radio buttons and checkboxes with labels
- Added white-space: nowrap to prevent text wrapping
- Enhanced alignment consistency with vertical-align: middle
- Fixed checkbox label structure for proper semantic HTML
- Refined spacing variables for precise Figma matching
@sonarqubecloud
Copy link
Copy Markdown

@pavanputti pavanputti added Medium Priority and removed do not review Do not review or look at code without full context labels Nov 22, 2025
@pavanputti pavanputti changed the title Set up CSS structure for filter alignment to match Figma design Siva - Fix Dates and Online Filters” Misalignment Feb 1, 2026
@pavanputti pavanputti force-pushed the siva/fix-filter-alignment-figma-match-clean branch 2 times, most recently from d3a0d4e to 67c2c99 Compare February 22, 2026 01:03
@pavanputti pavanputti force-pushed the siva/fix-filter-alignment-figma-match-clean branch from 67c2c99 to fd567a4 Compare February 22, 2026 01:05
@one-community one-community added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed Medium Priority labels Mar 8, 2026
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I tested this PR locally. The radio buttons and checkbox should be on the left side of the labels, and the “Online Only” text is not aligned in the same row as the checkbox. Could you please check this?

Image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Siva,

I have reviewed your PR locally and mentioned by the other reviewer "Online Only" is not aligned as per requirement, else the application UI is as per requirement.

Image Image

…ix-filter-alignment-figma-match-clean"

This reverts commit d4ab1d7, reversing
changes made to fd567a4.
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Siva,

Well done with this implementation.

PR 4388 Screenshot

- Move Dates/Online section headers to divs; align radio/checkbox with labels
- Give radio and checkbox explicit size (18px) and gap to prevent overlap
- Override Bootstrap form-check positioning so flex layout controls spacing
- Online Only uses FormGroup+Label for consistent alignment with date options
Resolved conflicts:
- CPDashboard.jsx: removed duplicate Show Past Events block (keep header button only)
- CPDashboard.module.css: kept filter alignment/overlap fix, merged development styles, removed duplicate selectors
- ActivityComments.jsx: use feedbackSearchInput class for feedback search input
- Override display: inline for filter option labels so they stay beside control
- Add flex-wrap: nowrap to checkboxGroup to prevent wrapping
Copy link
Copy Markdown

@Vishnu10-hub Vishnu10-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Siva,

Checked the PR locally, everything looks correct and well-implemented.

Image

…r-alignment-figma-match-clean

# Conflicts:
#	package.json
#	public/index.css
#	src/actions/bmdashboard/equipmentActions.js
#	src/components/ApplicantVolunteerRatio/ApplicantVolunteerRatio.jsx
#	src/components/BMDashboard/Equipment/DailyActivityLog/EDailyActivityLog.jsx
#	src/components/BMDashboard/Equipment/DailyActivityLog/EDailyActivityLog.module.css
#	src/components/BMDashboard/Tools/SimpleToolChart.jsx
#	src/components/BMDashboard/WeeklyProjectSummary/MostFrequentKeywords/MostFrequentKeywords.jsx
#	src/components/BMDashboard/WeeklyProjectSummary/MostFrequentKeywords/MostFrequentKeywords.module.css
#	src/components/BMDashboard/WeeklyProjectSummary/WeeklyProjectSummary.jsx
#	src/components/BMDashboard/WeeklyProjectSummary/WeeklyProjectSummary.module.css
#	src/components/Collaboration/Collaboration.jsx
#	src/components/Collaboration/Collaboration.module.css
#	src/components/Collaboration/JobFormbuilder.jsx
#	src/components/Collaboration/QuestionSetManager.jsx
#	src/components/CommunityPortal/Activities/ActivityList.jsx
#	src/components/CommunityPortal/Activities/ActivityList.module.css
#	src/components/CommunityPortal/Activities/activityId/ResourcesUsage.jsx
#	src/components/CommunityPortal/CPDashboard.module.css
#	src/components/CommunityPortal/EventPersonalization/EventStats.jsx
#	src/components/CommunityPortal/EventPersonalization/EventStats.module.css
#	src/components/HGNHelpSkillsDashboard/CommunityMembersPage.jsx
#	src/components/HGNHelpSkillsDashboard/TeamCard/TeamCard.jsx
#	src/components/HGNHelpSkillsDashboard/TeamCard/TeamCard.module.css
#	src/components/HGNHelpSkillsDashboard/TeamCard/TeamMemberRow.jsx
#	src/components/HGNSkillsDashboard/SkillsProfilePage/components/ProfileDetails.jsx
#	src/components/HGNSkillsDashboard/SkillsProfilePage/styles/Skills.module.css
#	src/components/LBDashboard/Messaging/LBMessaging.module.css
#	src/components/PRGradingScreen/PRGradingScreen.jsx
#	src/components/PRGradingScreen/PRGradingScreen.module.css
#	src/components/Projects/WBS/SingleTask/SingleTask.jsx
#	src/components/TeamMemberTasks/TeamMemberTask.jsx
#	src/components/TeamMemberTasks/style.module.css
#	src/components/UserProfile/TeamsAndProjects/AddProjectPopup.jsx
#	src/components/UserProfile/TeamsAndProjects/AddTeamPopup.jsx
#	src/components/WeeklySummariesReport/WeeklySummariesReport.jsx
#	src/components/WeeklySummariesReport/WeeklySummariesReport.module.css
#	src/routes.jsx
#	src/utils/URL.js
#	yarn.lock
@sonarqubecloud
Copy link
Copy Markdown

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit c59adcb into development Apr 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants