Dipti listing and bidding dashboard login page show password option#4513
Conversation
dipti95
added
the
High Priority - Please Review First
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Prem203
left a comment
Prem203
left a comment
There was a problem hiding this comment.
Reviewed the PR with an admin account and the password is visible when the eye/show button is clicked.
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Dipti,
I have reviewed your PR locally and the functionality works as expected but as you can see in the below image, the show icon overlaps with the text box.
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Overall nice implementation. Need to adjust the UI slightly on the eye as it's overlapping. See images below.
|
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Dipti,
Thanks for fixing the issue previously mentioned, i have re-reviewed it.
ShreyaMP1999
left a comment
ShreyaMP1999
left a comment
There was a problem hiding this comment.
Hi Dipti,
I have reviewed your PR locally and the functionality works as expected
Screen.Recording.2026-01-02.at.12.25.31.PM.mov
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Dipti,
You have fixed the overlapping issue.
A query - Is it possible to keep it static? As you can see in the screenshots, it shrinks and expands depending on which option is chosen.
|
Thank you all, merging! |
7 participants
Description
Related PRS (if any):
This frontend PR is related to the development branch backend PR.
Main changes explained:
…
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
AfterChange.mp4