Skip to content

Ramsundar - Fixed the search error on Member Group Check In#4760

Merged
one-community merged 3 commits into
developmentfrom
Fix-Search-Error-in-Member-Group-Check-In
May 8, 2026
Merged

Ramsundar - Fixed the search error on Member Group Check In#4760
one-community merged 3 commits into
developmentfrom
Fix-Search-Error-in-Member-Group-Check-In

Conversation

@Ram-blip
Copy link
Copy Markdown
Contributor

Description

Screenshot 2026-01-24 at 11 39 38 AM

Screenshot 2026-01-24 at 11 39 58 AM

Related PRS (if any):

This frontend PR is related to the latest development branch.

Main changes explained:

  • Add null safety checks and optional chaining to prevent crashes when searching members by name, role, or team. Improve empty state messaging to differentiate between no matches and no members.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Go to "/bmdashboard/timelog" and Select any project, Search using name, role.

Screenshots or videos of changes:

Video Proof after changes:
https://www.loom.com/share/589f1a1c3e3049c8b2dd7d820ca00cb2

Note:

Include the information the reviewers need to know.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 24, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 39d6a41
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69fc71229da96200080cbcf6
😎 Deploy Preview https://deploy-preview-4760--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label May 5, 2026
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ramsundar,

The functionality is working fine. However, the start, stop, and clear buttons along with the timer UI need some improvement. Please check if this falls under the scope of this PR.

Image Image Image

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@Ram-blip
Copy link
Copy Markdown
Contributor Author

Ram-blip commented May 7, 2026

Hi Ramsundar,

The functionality is working fine. However, the start, stop, and clear buttons along with the timer UI need some improvement. Please check if this falls under the scope of this PR.

Image Image Image

Hey Hemanth,

My goal for this PR was to fix the search error in the Member Group Check In page and make sure users can search by name, role, or team without any console errors. I don’t have much idea about the start, stop, clear buttons, and timer UI because they were already like this before my change, so I believe that is outside the scope of this PR. Thank you for your review.

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging! I'll have someone else improve the timer UI

@one-community one-community merged commit 5c0ea08 into development May 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants