Veda Review Volume Over Time chart#5012
Conversation
Made-with: Cursor
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
There was a problem hiding this comment.
Hi Charitha,
I reviewed your PR locally and noticed that the date range filtering, particularly when manually selecting the “from” and “to” dates, appears to be inconsistent. And the selected month is not visible properly.Please refer to the images below for better visualization.
Made-with: Cursor
Normalize date filtering to month keys to prevent inconsistent from/to results, and improve month picker dark-mode/selection visibility and field alignment. Made-with: Cursor
Extract select style creation and custom date filter UI into focused helpers to keep logic equivalent while satisfying Sonar complexity limits. Made-with: Cursor
Simplify conditional rendering and option styling logic to reduce component complexity, and adjust dark-mode month selection color for sufficient contrast. Made-with: Cursor
saisandeepkoritala
left a comment
saisandeepkoritala
left a comment
There was a problem hiding this comment.
Hi Charitha,
I reviewed your PR locally and confirmed that the earlier issues with the date range filtering and manual “from” and “to” date selection have been fixed. However, I noticed that for screen sizes above 768px, the alignment appears slightly off. Please take a look at that area for better consistency.
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Charitha,
I reviewed your PR locally and the date range filtering and manual "from" and "to" date selection are working as expected. However, I noticed that the year is not clearly visible in the calendar.
Stack title and sentiment legend below 900px and prevent legend items from overlapping at mid viewport widths. Made-with: Cursor
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Veda,
Well done with this implementation.
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Charitha,
I have reviewed your PR locally and though all functionalities work as per requirement. The year in the calendar is still not visible clearly in dark mode.
Issues
Working screenshots
|
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Charitha,
Thank you for working on the improvements. The year is now clearly visible in the calendar.
|
Thank you all, merging! |
6 participants
Made-with: Cursor
Description
Related PRS (if any):
This frontend PR is related to the development backend PR.
This PR reflects the changes for existing PR - 4693
Main changes explained:
How to test:
npm installand...to run this PR locally• Select By Village and confirm village multi select is enabled and property multi select is disabled
• Select By Property and confirm property multi select is enabled and village multi select is disabled
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.