Siri SudheekshaVavila: Fix bm separate add equipment tool forms#5206
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
one-community
added
the
High Priority - Please Review First
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sudheeksha,
I tested this PR locally. "Add Equipment" is not working. On the Add Tool form, validation is not working for some fields like the mobile number field and the country code is not aligned correctly in dark mode. The Add Equipment form UI also needs improvement as it is not user friendly.
rajanidi1999
left a comment
rajanidi1999
left a comment
There was a problem hiding this comment.
Hi,
I checked out the branch fix-bm-separate-add-equipment-tool-forms, installed dependencies, and ran the application locally. After clearing the browser cache and logging in as an admin, I navigated to the BM Dashboard and accessed a project page. The dropdown in the top header now correctly displays “Add Equipment” and “Add Tool” as separate options. Both buttons function as expected clicking “Add Equipment” navigates to the Equipment form at /bmdashboard/equipment/add, and “Add Tool” navigates to the Tool form at /bmdashboard/tools/add. The new feature works as intended with proper routing and UI behavior, and no issues were observed during testing.
sirisudheeksha
dismissed
HemanthNidamanuru’s stale review
fixed the changes and requested re- review
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sudheeksha,
Thank you for working on this PR.
Issues found during testing:
Country code dropdown needs improvement in dark mode on the Add Tool form.
Calendar icon and calendar styling need improvement in dark mode.
Add Equipment form UI needs improvement for better usability. Please review the layout and spacing.
Form validation errors should be displayed in red so users can clearly identify which fields are missing or invalid.
sirisudheeksha
dismissed
HemanthNidamanuru’s stale review
Fixed the dark mode error messages in add tools and UI for add equipment
sirisudheeksha
force-pushed
the
fix-bm-separate-add-equipment-tool-forms
branch
from
5b3ac1a to
b253fe1
Compare
…ode/phone alignment - Fix AddTypeForm: send 'description' key instead of 'desc' to match backend schema - Fix AddTypeForm: correct Submit button disabled logic (|| instead of &&) - Fix AddTypeForm: reset fuel to default value on successful submit - Fix AddToolForm: fix PhoneInput country prop to lowercase 'us' - Fix AddToolForm: wrap PhoneInput in FormGroup with label, fix input width alignment - Fix AddToolForm: add dark mode styles to PhoneInput (input, button, dropdown) - Fix AddToolForm: add dark mode styling for total price section - Fix AddToolForm: apply boxStyleDark to Cancel/Submit buttons in dark mode
…color, and equipment form layout
…r equipment form card
sirisudheeksha
force-pushed
the
fix-bm-separate-add-equipment-tool-forms
branch
from
b253fe1 to
b452c68
Compare
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sudheeksha,
I tested this PR locally. The country code dropdown, calendar icon and styling, Add Equipment form layout, and form validation error colors are all looking good. A few remaining issues to address:
- Phone number field has no validation. Please add validation to ensure only valid phone numbers are accepted.
- Dark mode still has some styling issues. Please audit and fix the affected elements.
- In the Add Equipment form, duplicate entries can be submitted with no validation preventing it. Please add a check to block duplicate records.
- Two dropdown arrows are appearing in the form in dark mode. Please remove the extra one so only a single arrow is shown.
…lexity, fix negated conditions, extract nested ternaries
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sudheeksha,
I tested this PR locally. The country code dropdown, calendar icon and styling, Add Equipment form layout, and form validation error colors are all looking good. One remaining issue to address:
Phone number validation is not enforcing country-specific lengths. For USA, a 9-digit number is being accepted when exactly 10 digits are required. Please update the validation to check the expected digit count based on the selected country code rather than using only the generic 6–15 range.
…ther than generic 6-15 range
…ate, flip negated submit condition
sirisudheeksha
dismissed
HemanthNidamanuru’s stale review
implemented the requested changes and requested a re review
…ube readability issue
…narQube readability issue
|
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sudheeksha,
Thank you for working on improvements. Everything looks good.
|
Thank you all, merging! |
4 participants
Description
Currently both Equipment and Tool share a single "Add Equipment/Tool" dropdown entry in the BM Dashboard header navigation and a single "Tool/Equipment" button in the project page LogBar. Both point to only one form, making the Tool add form inaccessible from the UI. This fix separates them into two distinct entries so each form is independently reachable.
Or Implements # (WBS)
Related PRS (if any):
…
Main changes explained:
…
How to test:
Screenshots or videos of changes:
Before:
Note:
Include the information the reviewers need to know.