Diya 🔥 fix(build): Fixed build issues in Surge#5214
Merged
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
one-community
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the GitHub Actions CI build failure on the
developmentbranch caused bynpm cifailing due to missingpackage-lock.json.Fixes: Surge build failure —
npm error code EUSAGE/ missing package-lock.jsonRelated PRs (if any):
None
Main changes explained:
package-lock.jsonfrom.gitignore(it was listed twice) so it is now tracked by gitpackage-lock.jsonto the repository sonpm ciin GitHub Actions can run successfullyHow to test:
package-lock.jsonexists at the root of the projectnpm cilocally to confirm it installs without errorsNote:
package-lock.jsonshould always be committed for applications (not libraries) to ensure reproducible builds across all environments. It was previously added to.gitignoreby mistake which causednpm cito fail in CI since that command requires a lockfile. This fix ensures the Surge deployment pipeline can run successfully.