Skip to content

Sayali : fix ALL-TIME members list showing incorrect count in Project Report#5225

Merged
one-community merged 1 commit into
developmentfrom
Sayali-Fix-AllTime-Members-ProjectReport
May 18, 2026
Merged

Sayali : fix ALL-TIME members list showing incorrect count in Project Report#5225
one-community merged 1 commit into
developmentfrom
Sayali-Fix-AllTime-Members-ProjectReport

Conversation

@sayali-2308
Copy link
Copy Markdown
Contributor

@sayali-2308 sayali-2308 commented May 3, 2026

image

Description

Fixes #1 (Priority Medium) - Fix the Projects Report incomplete Members list when the ALL-TIME button is selected.

Related PRs (if any):

This frontend PR is related to this backend PR OneCommunityGlobal/HGNRest#2225
Previous related work: #2532 (already merged).

Main changes explained:

  • Updated ProjectMemberTable.jsx to fix useEffect dependency array to include members and foundUsers so the member lists rebuild correctly when data changes
  • Added reset logic to clear member lists when project is not yet fetched, preventing stale data from previous project
  • Added memberFilter reset to 'active' when switching between projects
  • Fixed member count handler to update correctly when toggling between ACTIVE and ALL-TIME

How to test:

  1. Check out branch Sayali-Fix-AllTime-Members-ProjectReport
  2. npm install && npm run start:local
  3. Clear site data/cache
  4. Log as admin user
  5. Go to Reports → Reports → Projects → select any project (e.g. HG Food)
  6. Verify ACTIVE and ALL-TIME counts are different
  7. Click ALL-TIME — verify it shows more members including inactive ones (hollow dot)
  8. Switch to another project — verify members update immediately without showing previous project's members
  9. Verify dark mode works

Screenshots or videos of changes:

image image

Note:

@netlify
Copy link
Copy Markdown

netlify Bot commented May 3, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit a3d1b02
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69f69291e31e95000876f467
😎 Deploy Preview https://deploy-preview-5225--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 3, 2026

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I tested this locally. ACTIVE and ALL-TIME counts show different values as expected. ALL-TIME view correctly includes inactive members with hollow dots. Switching projects updates the member list immediately with no leftover data from the previous project. Dark mode looks good too.

Image Image Image Image

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit a473024 into development May 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants