Skip to content

Conversation

@EvianTan
Copy link
Contributor

@EvianTan EvianTan commented Mar 10, 2023

Description

image
This PR is for URGENT bug #1
This PR is ONLY for adding one more tab on weekly summaries dashboard, to show the weekly summary of "three weeks ago".
This PR doesn't have any contribution on fixing the "total submitted".

Related PRS (if any):

#622 Alan worked on this before but didn't get it completed. I'm going to close it since I'll raise new ones.

Mainly changes explained:

src/components/WeeklySummary/WeeklySummary.jsx: update the UI and properties to make the weekly summaries dashboard show 4 tabs instead of 3, add dueDateThreeWeeksAgo, summaryThreeWeeksAgo, etc.
src/components/WeeklySummary/WeeklySummary.test.jsx: update test suites to pass the run npm test command.

How to test:

check into current branch
do npm install and ... to run this PR locally
log as any role user or a new created user
go to dashboard→ weekly summaries
verify adding summaries on the 4 tabs can work

Screenshots or videos of changes:

image

Note:

  1. I made some changes on the Dev database for testing this PR
    Before my change, weeklySummaries in Dev database somehow showed the three dates identical, both of them are the current week's due date. This link shows how the identical due dates problem found.
    I used below commands to update the due dates to be correct. Since the due dates in our Beta database are correct, I didn't make any changes there.
    image

  2. From the below discussion, we decide to improve the current logic of counting "total submitted", I'll try to fix this part next week, in my next PR.
    image

@crystalsong2021
Copy link

crystalsong2021 commented Mar 11, 2023

@EvianTan I tested and confirmed the additional tab on weekly summaries. Nicely done!
Untitled design (2)

@johny4437
Copy link
Contributor

johny4437 commented Mar 11, 2023

HI @EvianTan I tested the PR, I have one questions and one observation.
1 -Will a "three weeks ago" tab be added to the Weekly Summary Report page in the future?
Captura de Tela (256)

2 - I am getting an error in the console. Can this be fixed?
Captura de Tela (255)

3- after save the three weeks ago summary the page is not clickable, the it is necessary to refresh thhe page.

Copy link

@crystalsong2021 crystalsong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working hard on this PR with adding tab to the weekly summaries.
note: I am also getting the same error in with weeklySummary.jsx regarding uncaught promise.

@mpavithr
Copy link

Hi, I tested the PR and I do see the additional tab. However, if I add a paragraph to the three weeks ago summary and click save, I'm not able to click anything again on the page until I refresh the page.

pr707_2

Copy link
Contributor

@Lucas-E Lucas-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this message finds you well. I wanted to inform you that I have tested your Pull Request and found the code to be working very well. However, I did encounter an error in the console after submitting. Nevertheless,
Captura de tela de 2023-03-11 12-50-48
excellent job!

Copy link

@kangjay88 kangjay88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EvianTan, I have tested this PR and the '3 Weeks Ago Summary' does save and show. However, I am also not able to click anything else after submitting. This is also the case when I created a summary for 'last week's summary' and 2 weeks ago summary, unless I reload the page - maybe in a separate PR, code should implement a reload after saving?

HGN.APP.-.Google.Chrome.2023-03-11.10-53-53.mp4

@nicollext
Copy link
Contributor

Hey @EvianTan! I tested and it is working as expected. I also was not able to click the page after submitting the summary, but I tested the development branch and the error and the click behavior were already present. Maybe we could open a PR to solve this problem.

Before

Yiyun-add_one_more_tab_for_weekly_summaries_1.MP4

After

Yiyun-add_one_more_tab_for_weekly_summaries.MP4

@vitorsaa2k
Copy link
Contributor

The new tab is appearing and working normally but im getting the same arror as everyone else.

image

Copy link
Contributor

@PrabhjotSembhi PrabhjotSembhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's working fine.
here are some things that need to be addressed.

  1. after submitting a summary for any week page become unresponsive. You have reloaded it.
  2. We don't have 4 tabs for 4 weeks in Summary Reports
  3. Our tab naming is not consistent.

https://user-images.githubusercontent.com/82662768/225733624-5bfb8d5d-b979-421f-9a49-9f1b88471dee.mp4
check at 44 seconds it becomes unresponsive and it's still scrollable but I cant click anything.

707

You can here we have 3 tabs only and Plays makes names consistent which will make it easy to monitor.

@NyahJ
Copy link

NyahJ commented Mar 17, 2023

Hi @EvianTan,
Thanks for your hard work on this PR, I have tested your change, there are four tabs: shows the summaries from current week to last 3 weeks. However, the names were incorrect, shown like the following image, could you pls take a look at this?

截屏2023-03-17 下午3 35 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.