Skip to content

add a 'deprecated' class to fields which have been marked as such#39

Merged
sgrove merged 1 commit intoOneGraph:masterfrom
agrimetrics:master
Jan 19, 2020
Merged

add a 'deprecated' class to fields which have been marked as such#39
sgrove merged 1 commit intoOneGraph:masterfrom
agrimetrics:master

Conversation

@TimLehner
Copy link
Copy Markdown
Contributor

This allows more flexible styling of deprecated fields, e.g. using the following CSS to strikethrough the deprecated fields:

.graphiql-explorer-node.deprecated {
  span {
    span {
      text-decoration: line-through;
      font-style: italic;
    }
  }
}

@sgrove sgrove self-requested a review January 19, 2020 21:40
@sgrove
Copy link
Copy Markdown
Contributor

sgrove commented Jan 19, 2020

This is great, thank you!

Copy link
Copy Markdown
Contributor

@sgrove sgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sgrove sgrove merged commit 55b5837 into OneGraph:master Jan 19, 2020
@sgrove
Copy link
Copy Markdown
Contributor

sgrove commented Jan 21, 2020

Note that I changed the classname in #41 to be more specific and slightly changed where it was applied, graphiql-explorer-deprecated. This should make it less likely to collide with existing CSS and also make targeting just the field nodes easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants