Skip to content

zaakstatus datumstatusgezet fix incl. validation#116

Merged
ragaumon merged 2 commits intomainfrom
bugfix/FUND-2188-ZRC-get-status-does-not-return-Z-for-time
Dec 5, 2025
Merged

zaakstatus datumstatusgezet fix incl. validation#116
ragaumon merged 2 commits intomainfrom
bugfix/FUND-2188-ZRC-get-status-does-not-return-Z-for-time

Conversation

@heuvea
Copy link
Copy Markdown
Contributor

@heuvea heuvea commented Nov 28, 2025

Pull Request

Description

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Related Issues

Testing

  • Tests pass
  • Manual testing completed

Checklist

  • Self-review completed
  • Documentation updated (if needed)

Copilot AI review requested due to automatic review settings November 28, 2025 10:32
@heuvea heuvea added Bug Something isn't working Zaken API Related to Zaken (ZRC) component labels Nov 28, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the handling of datetime fields for zaakstatus, specifically addressing the datumStatusGezet field format and adding proper validation. The changes ensure datetime values are correctly formatted as UTC/ISO 8601 and validated to prevent future dates.

Key changes:

  • Changed datetime formatting from local time to UTC with explicit 'Z' timezone indicator
  • Enhanced the NotInTheFuture validation to properly parse UTC timestamps with culture-invariant settings

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/OneGround.ZGW.Common/Helpers/ProfileHelper.cs Updated SortableStringDateFromDate to format dates as UTC ISO 8601 with explicit format string
src/OneGround.ZGW.Common.Web/Validations/IRuleBuilderExtensions.cs Enhanced NotInTheFuture validation to properly parse UTC datetime strings with culture-invariant parsing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/OneGround.ZGW.Common/Helpers/ProfileHelper.cs Outdated
Comment thread src/OneGround.ZGW.Common.Web/Validations/IRuleBuilderExtensions.cs Outdated
@heuvea heuvea changed the title zaakstatus datumstatusgezet fiex incl. validation zaakstatus datumstatusgezet fix incl. validation Nov 28, 2025
@ragaumon ragaumon force-pushed the bugfix/FUND-2188-ZRC-get-status-does-not-return-Z-for-time branch 2 times, most recently from 4c19e2f to 4f01328 Compare December 3, 2025 17:54
@ragaumon ragaumon requested a review from Copilot December 3, 2025 17:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/OneGround.ZGW.Common.Web/Validations/IRuleBuilderExtensions.cs
Comment thread src/OneGround.ZGW.Common/Helpers/ProfileHelper.cs Outdated
@ragaumon ragaumon requested a review from Copilot December 3, 2025 18:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ragaumon ragaumon force-pushed the bugfix/FUND-2188-ZRC-get-status-does-not-return-Z-for-time branch from 37ce57c to 4f01328 Compare December 4, 2025 11:34
@ragaumon ragaumon requested a review from Copilot December 4, 2025 11:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ragaumon ragaumon force-pushed the bugfix/FUND-2188-ZRC-get-status-does-not-return-Z-for-time branch from 4f01328 to c423668 Compare December 4, 2025 12:29
@ragaumon ragaumon merged commit ba95d2e into main Dec 5, 2025
2 checks passed
@ragaumon ragaumon deleted the bugfix/FUND-2188-ZRC-get-status-does-not-return-Z-for-time branch December 5, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Zaken API Related to Zaken (ZRC) component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants