Conversation
heuvea
added
Bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a production issue (FUND-2345) where a DRC-500 error occurs during DELETE operations in DocumentKenmerkenResolver. The root cause is a null LatestEnkelvoudigInformatieObjectVersie foreign key reference that occurs in production environments.
Changes:
- Added defensive null-checking workaround in multiple
LockEnkelvoudigInformatieObjectCommandHandlerfiles (v1, v1.1, v1.5) to restore the latest version when null - Refactored
DocumentKenmerkenResolver.GetKenmerkenAsyncto handle nullLatestEnkelvoudigInformatieObjectVersieby falling back to the latest version from the collection
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/OneGround.ZGW.Documenten.Web/Handlers/v1/LockEnkelvoudigInformatieObjectCommandHandler.cs | Added null check and restore logic for LatestEnkelvoudigInformatieObjectVersie with warning log |
| src/OneGround.ZGW.Documenten.Web/Handlers/v1/5/LockEnkelvoudigInformatieObjectCommandHandler.cs | Added identical null check and restore logic as v1 handler |
| src/OneGround.ZGW.Documenten.Web/Handlers/v1/1/LockEnkelvoudigInformatieObjectCommandHandler.cs | Added identical null check and restore logic as v1 handler |
| src/OneGround.ZGW.Documenten.Web/Handlers/DocumentKenmerkenResolver.cs | Introduced null-coalescing fallback to compute latest version when LatestEnkelvoudigInformatieObjectVersie is null |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Grabauskas
approved these changes
Jan 23, 2026
heuvea
deleted the
bugfix/FUND-2345-DRC-500-error-on-DELETE-DocumentKenmerkenResolver
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Type of Change
Related Issues
Testing
Checklist