OK-3199: UTXO model supporting #894

huazhouwang · 2021-08-23T13:06:44Z

What does this implement/fix? Explain your changes.

整理 BTCProvider 结构
补全 BTCProvider 以及 Blockbook
BTCProvider 支持 MessageSupportingMixin
BTCProvider 支持硬件签名
新增 utxo_manager
更新 wallet_manager
更新 console
测试

Does this close any currently open issues?

If it fixes a bug or resolves a feature request, be sure to link to that issue.
…

Pull request type

Put an x in the boxes that apply

Where has this been tested?

…

Any other comments?

…

huazhouwang · 2021-08-23T13:07:56Z

@shuaiLiWang 还未做完，可以提前看下

electrum_gui/common/provider/chains/btc/hardware_mixin.py

electrum_gui/common/provider/chains/btc/blockbook.py

huazhouwang · 2021-08-31T10:22:57Z

基本完成，还差测试用例，可以 review 了

taimanhui

一个大工程...

electrum_gui/common/provider/chains/btc/hardware_mixin.py

electrum_gui/common/provider/chains/btc/blockbook.py

electrum_gui/common/provider/chains/btc/provider.py

electrum_gui/common/provider/chains/btc/blockbook.py

electrum_gui/common/utxo/utxo_chooser.py

electrum_gui/common/wallet/manager.py

dydysy

👀

electrum_gui/common/provider/chains/btc/blockbook.py

dydysy

没啥想法了。
utxo 的选择，也有交给用户去选择处理的。不过这些都是高阶用户才能理解的功能。

taimanhui

一些小疑问，其它的都没啥问题，先合并之后看看效果吧

electrum_gui/common/provider/chains/btc/hardware_mixin.py

electrum_gui/common/provider/chains/btc/provider.py

electrum_gui/common/utxo/manager.py

dydysy · 2021-09-10T02:25:32Z

pycoin使用的时候，没有牵扯到里面加密的部分吧，我看这个库使用了c扩展

具体指哪个文件？我之前看它确实有些地方会优先请求 c 扩展，但如果没有就用备份的 python 实现

那和 msgpack 一样。也是先c，后python。

taimanhui · 2021-09-17T03:03:30Z

electrum_gui/common/provider/interfaces.py

 class MessageSupportingMixin(abc.ABC):
    @abc.abstractmethod
-    def sign_message(self, message: str, signer: secret_interfaces.SignerInterface) -> str:
+    def sign_message(self, message: str, signer: secret_interfaces.SignerInterface, **kwargs) -> str:


后面这个的**kwargs加入来是给什么用的？

btc 需要提供地址

没注意到 😂 又回去看了一遍btc那个mixin...

Fixes: 084af6b "Update console" (in PR OneKeyHQ#894) Signed-off-by: taimanhui <taimanhui@protonmail.com>

shuaiLiWang reviewed Aug 25, 2021

View reviewed changes

huazhouwang force-pushed the btc branch from 25f53cc to 069ccf5 Compare August 31, 2021 10:19

huazhouwang changed the title ~~[WIP] UTXO supporting~~ UTXO supporting Aug 31, 2021

huazhouwang changed the title ~~UTXO supporting~~ OK-3199: UTXO supporting Aug 31, 2021

huazhouwang requested review from dydysy, somebodyLi and taimanhui August 31, 2021 10:22

huazhouwang requested a review from shuaiLiWang August 31, 2021 10:24

huazhouwang force-pushed the btc branch from 069ccf5 to 8859dfe Compare September 1, 2021 16:11

huazhouwang changed the title ~~OK-3199: UTXO supporting~~ OK-3199: UTXO model supporting Sep 2, 2021

huazhouwang force-pushed the btc branch from 8859dfe to bbebb7e Compare September 2, 2021 13:27

taimanhui reviewed Sep 3, 2021

View reviewed changes

dydysy reviewed Sep 3, 2021

View reviewed changes

electrum_gui/common/provider/chains/btc/blockbook.py Show resolved Hide resolved

huazhouwang force-pushed the btc branch 2 times, most recently from 6fbc84b to c97dc5f Compare September 3, 2021 10:12

dydysy previously approved these changes Sep 6, 2021

View reviewed changes

huazhouwang dismissed dydysy’s stale review via 0e19950 September 6, 2021 09:46

huazhouwang force-pushed the btc branch 3 times, most recently from 16e1de3 to 08cdf66 Compare September 7, 2021 02:58

huazhouwang requested review from dydysy and taimanhui September 7, 2021 02:59

huazhouwang force-pushed the btc branch from 08cdf66 to 4640795 Compare September 7, 2021 10:23

taimanhui previously approved these changes Sep 7, 2021

View reviewed changes

electrum_gui/common/provider/chains/btc/hardware_mixin.py Show resolved Hide resolved

electrum_gui/common/provider/chains/btc/provider.py Show resolved Hide resolved

electrum_gui/common/utxo/manager.py Show resolved Hide resolved

electrum_gui/common/utxo/manager.py Show resolved Hide resolved

huazhouwang dismissed taimanhui’s stale review via 39b7bad September 8, 2021 03:26

huazhouwang force-pushed the btc branch from 4640795 to 39b7bad Compare September 8, 2021 03:26

taimanhui previously approved these changes Sep 8, 2021

View reviewed changes

huazhouwang dismissed taimanhui’s stale review via 98647df September 8, 2021 10:24

huazhouwang dismissed stale reviews from dydysy and taimanhui via eef654f September 10, 2021 02:22

huazhouwang force-pushed the btc branch from 9ceb30a to eef654f Compare September 10, 2021 02:22

huazhouwang requested review from dydysy and taimanhui September 10, 2021 02:23

huazhouwang force-pushed the btc branch from eef654f to 484312c Compare September 10, 2021 03:10

taimanhui previously approved these changes Sep 10, 2021

View reviewed changes

huazhouwang dismissed taimanhui’s stale review via d515732 September 15, 2021 10:30

huazhouwang force-pushed the btc branch 2 times, most recently from d515732 to d39468a Compare September 16, 2021 02:33

huazhouwang requested a review from taimanhui September 16, 2021 02:35

taimanhui previously approved these changes Sep 17, 2021

View reviewed changes

huazhouwang added 8 commits September 17, 2021 10:45

Reorganize BTCProvider

967a723

Fill BTCProvider

674ec2e

BTCProvider supports MessageSupportingMixin

5af191f

Fill BTCHardwareMixin.hardware_sign_transaction

b9dea6f

Add utxo_manager

5521eae

Update wallet_manager

3080de4

Update console

084af6b

Update TestCases

5ab8231

huazhouwang dismissed taimanhui’s stale review via 5ab8231 September 17, 2021 02:54

huazhouwang force-pushed the btc branch from d39468a to 5ab8231 Compare September 17, 2021 02:54

taimanhui approved these changes Sep 17, 2021

View reviewed changes

shuaiLiWang approved these changes Sep 17, 2021

View reviewed changes

huazhouwang marked this pull request as ready for review September 17, 2021 03:57

mergify bot merged commit 24e1eed into OneKeyHQ:bixin_dev Sep 17, 2021

huazhouwang deleted the btc branch September 17, 2021 03:57

taimanhui added a commit to taimanhui/electrum that referenced this pull request Oct 15, 2021

console: remove outdated check in verify_message

1394bc1

Fixes: 084af6b "Update console" (in PR OneKeyHQ#894) Signed-off-by: taimanhui <taimanhui@protonmail.com>

taimanhui added a commit to taimanhui/electrum that referenced this pull request Oct 15, 2021

console: remove outdated check in verify_message

ec92093

Fixes: 084af6b "Update console" (in PR OneKeyHQ#894) Signed-off-by: taimanhui <taimanhui@protonmail.com>

OK-3199: UTXO model supporting #894

OK-3199: UTXO model supporting #894

Uh oh!

Conversation

huazhouwang commented Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Pull request type

Where has this been tested?

Any other comments?

Uh oh!

huazhouwang commented Aug 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huazhouwang commented Aug 31, 2021

Uh oh!

taimanhui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dydysy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dydysy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taimanhui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dydysy commented Sep 10, 2021

Uh oh!

taimanhui Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

huazhouwang Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

taimanhui Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

huazhouwang commented Aug 23, 2021 •

edited

Loading

dydysy left a comment •

edited

Loading