fix btc-only version issues

[lihuanhuan]

Summary by CodeRabbit

• New Features

  • The "FIDO Keys" option in the Settings screen is now hidden when Bitcoin-only mode is enabled.

• Bug Fixes

  • Improved progress updates during seed generation to ensure accurate UI feedback.

• Refactor

  • Enhanced internal logic to better handle address derivation messages based on Bitcoin-only mode, improving compatibility and filtering.

[coderabbitai]

Walkthrough

The updates adjust control flow and conditional logic in three files. Progress reporting in seed generation is refactored. UI elements for FIDO Keys are hidden in Bitcoin-only mode. Message type handling is filtered based on the Bitcoin-only flag.

Changes

Files	Change Summary
core/embed/trezorhal/se_thd89.c	Refactored seed generation progress loop and UI callback logic.
core/src/trezor/lvglui/scrs/homescreen.py	Wrapped FIDO Keys UI logic in Bitcoin-only conditionals.
core/src/apps/workflow_handlers.py	Filtered handler logic and message types based on Bitcoin-only flag.

Estimated code review effort

2 (10–30 minutes)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 24841fd and 9906b0d.

📒 Files selected for processing (3)

• core/embed/trezorhal/se_thd89.c (2 hunks)
• core/src/apps/workflow_handlers.py (2 hunks)
• core/src/trezor/lvglui/scrs/homescreen.py (3 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

core/src/trezor/lvglui/scrs/homescreen.py (1)

core/src/trezor/lvglui/scrs/components/button.py (1)

• ListItemBtn (88-206)

core/embed/trezorhal/se_thd89.c (1)

core/embed/trezorhal/common.c (1)

• hal_delay (294-294)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Gen check
• GitHub Check: Defs check
• GitHub Check: Style check

🔇 Additional comments (7)

core/src/apps/workflow_handlers.py (2)

395-399: Good defensive programming.

The null check prevents potential errors.

---

408-454: Proper Bitcoin-only mode implementation.

Conditional filtering correctly restricts message types based on the Bitcoin-only flag.

core/src/trezor/lvglui/scrs/homescreen.py (3)

1565-1570: LGTM - Clean conditional creation

---

1591-1592: LGTM - Consistent conditional access

---

1617-1617: LGTM - Proper short-circuit evaluation

core/embed/trezorhal/se_thd89.c (2)

1989-2003: LGTM - Clean refactor

Progress loop restructuring improves control flow.

---

2011-2025: LGTM - Consistent refactor

Same clean restructuring as cardano section.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[revan-zhang]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)