Fix/not support method

[ByteZhang1024]

Summary by CodeRabbit

Release Notes

• Chores

  • Released version 1.1.19 (stable release from alpha pre-release).
  • Updated all package dependencies to version 1.1.19.

• Bug Fixes

  • Enhanced error handling to include firmware type context for better device compatibility diagnostics.
  • Improved device method validation with structured error messages.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[revan-zhang]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Release version promotion from 1.1.19-alpha.8 to 1.1.19 across all packages. Updates package versions, dependencies, and refactors error handling to use new structured error factory functions with firmware type context.

Changes

Cohort / File(s)	Change Summary
Package version and dependency bumps packages/connect-examples/electron-example/package.json, packages/connect-examples/expo-example/package.json, packages/connect-examples/expo-playground/package.json, packages/core/package.json, packages/hd-ble-sdk/package.json, packages/hd-common-connect-sdk/package.json, packages/hd-transport-electron/package.json, packages/hd-transport-emulator/package.json, packages/hd-transport-http/package.json, packages/hd-transport-lowlevel/package.json, packages/hd-transport-react-native/package.json, packages/hd-transport-web-device/package.json, packages/hd-transport/package.json, packages/hd-web-sdk/package.json, packages/shared/package.json	Version bumped to 1.1.19; all internal dependencies updated from 1.1.19-alpha.8 to 1.1.19
Error factory refactoring packages/shared/src/HardwareError.ts	New function createDeviceNotSupportMethodError added. createNeedUpgradeFirmwareHardwareError and createNewFirmwareUnReleaseHardwareError signatures changed to accept structured object with currentVersion, requireVersion, methodName, and firmwareType. Added firmware-type guard for Bitcoin-only devices.
Error factory adoption packages/core/src/api/BaseMethod.ts, packages/core/src/api/tron/TronSignMessage.ts, packages/core/src/core/index.ts	Replaced ERRORS.TypedError calls with new error factory functions. Updated error calls to pass structured objects with firmware type context via getFirmwareType().
Error handling and signature updates packages/core/src/api/allnetwork/AllNetworkGetAddressBase.ts	Added getFirmwareType import. Updated error construction for firmware checks and device support validation. Broadened error detection to treat Failure_UnknownMessage as skippable.
Batch public key function refactor packages/core/src/api/helpers/batchGetPublickeys.ts	Added ecdsaCurveName and coinType parameters to function signature. Added path-length and coin-type validation. Introduced device-type-based batch sizing. Updated error handling to use new factory functions and structured error objects. Changed imports to type-only where applicable.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~35 minutes

• Package updates — 15 files with identical version bumps (homogeneous, ~1 min each across the group)
• Shared error module — New factory functions with conditional logic; requires validation of parameter object changes and firmware-type guard logic
• API file migrations — Five files adopting new error factories; verify consistent firmware-type passing via getFirmwareType()
• batchGetPublickeys refactor — Most complex change: new function parameters, validation logic, batch sizing, and error handling; requires careful verification of coin-type enforcement and path validation

Extra attention needed:

• Verify that all calls to createNeedUpgradeFirmwareHardwareError and createNewFirmwareUnReleaseHardwareError pass the new object format consistently
• Check batchGetPublickeys signature adoption across all call sites
• Confirm firmware-type guard in HardwareError.ts doesn't unintentionally suppress valid errors
• Validate coin-type and path-length checks in batch function logic

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/notSupportMethod

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3f2601d and 1a58e97.

📒 Files selected for processing (21)

• packages/connect-examples/electron-example/package.json (2 hunks)
• packages/connect-examples/expo-example/package.json (2 hunks)
• packages/connect-examples/expo-playground/package.json (2 hunks)
• packages/core/package.json (2 hunks)
• packages/core/src/api/BaseMethod.ts (3 hunks)
• packages/core/src/api/allnetwork/AllNetworkGetAddressBase.ts (4 hunks)
• packages/core/src/api/helpers/batchGetPublickeys.ts (3 hunks)
• packages/core/src/api/tron/TronSignMessage.ts (2 hunks)
• packages/core/src/core/index.ts (3 hunks)
• packages/hd-ble-sdk/package.json (2 hunks)
• packages/hd-common-connect-sdk/package.json (2 hunks)
• packages/hd-transport-electron/package.json (2 hunks)
• packages/hd-transport-emulator/package.json (2 hunks)
• packages/hd-transport-http/package.json (2 hunks)
• packages/hd-transport-lowlevel/package.json (2 hunks)
• packages/hd-transport-react-native/package.json (2 hunks)
• packages/hd-transport-web-device/package.json (2 hunks)
• packages/hd-transport/package.json (1 hunks)
• packages/hd-web-sdk/package.json (2 hunks)
• packages/shared/package.json (1 hunks)
• packages/shared/src/HardwareError.ts (4 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	eslint@​8.15.0 ⏵ 8.57.1
	https-browserify@​1.0.0
	@​keystonehq/​keystone-sdk@​0.4.1
	@​keystonehq/​bc-ur-registry-eth@​0.15.2
	process@​0.11.10
	browserify-zlib@​0.2.0
	buffer@​6.0.3
	stream-browserify@​3.0.0
	http-browserify@​1.7.0
	path-browserify@​0.0.0 ⏵ 1.0.1			+18
	@​onekeyfe/​react-native-ble-utils@​0.1.3 ⏵ 0.1.4	+2		+2	+3
	expo@​54.0.20
	react-native-safe-area-context@​5.6.1
	@​types/​react@​18.3.23 ⏵ 19.1.17	+1
	react-native-get-random-values@​1.11.0
	expo-linking@​8.0.8
	@​babel/​core@​7.28.0 ⏵ 7.28.5
	jszip@​3.10.1
	@​onekeyfe/​hd-ble-sdk@​1.1.16
	react-native-url-polyfill@​2.0.0
	@​ethersproject/​transactions@​5.8.0
	react-native-qrcode-svg@​6.3.15
	ripple-keypairs@​1.3.1
	expo-status-bar@​3.0.8
	events@​3.3.0
	lodash@​4.17.21
	@​keystonehq/​bc-ur-registry@​0.6.4
	react@​19.1.0
	react-native-ble-plx@​3.5.0
	@​onekeyfe/​hd-core@​1.1.16
	@​react-native-async-storage/​async-storage@​1.24.0
	@​ngraveio/​bc-ur@​1.1.13
	react-native-svg@​15.12.1
See 4 more rows in the dashboard

View full report