Skip to content

feat(setup): overhaul dialog data handling#128

Merged
theEvilReaper merged 3 commits into
mainfrom
rework/payloadHandling
Jul 3, 2026
Merged

feat(setup): overhaul dialog data handling#128
theEvilReaper merged 3 commits into
mainfrom
rework/payloadHandling

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

At the moment, there is a single large listener handling different cases when data is received from a dialog. This is not very maintainable and should be refactored. This PR introduces a new interface and dedicated handler implementations to process dialog data.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper requested a review from TheMeinerLP July 3, 2026 09:43
@theEvilReaper theEvilReaper self-assigned this Jul 3, 2026
@theEvilReaper theEvilReaper added the area: setup Everything related to the the setup module label Jul 3, 2026

@TheMeinerLP TheMeinerLP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw several same thing on other places

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Test results

 96 files   96 suites   50s ⏱️
 93 tests  88 ✅  5 💤 0 ❌
282 runs  267 ✅ 15 💤 0 ❌

Results for commit 9ec2306.

@TheMeinerLP TheMeinerLP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theEvilReaper theEvilReaper merged commit 622dcdf into main Jul 3, 2026
8 checks passed
@theEvilReaper theEvilReaper deleted the rework/payloadHandling branch July 3, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: setup Everything related to the the setup module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants