refactor: remove shared/phase module and migrate to Xerus#171
Merged
TheMeinerLP merged 1 commit intomainfrom Apr 25, 2026
Merged
refactor: remove shared/phase module and migrate to Xerus#171TheMeinerLP merged 1 commit intomainfrom
TheMeinerLP merged 1 commit intomainfrom
Conversation
Closes #166 - Delete shared/phase module (net.elytrarace.api.phase.*) entirely - server: platform layer (MinestomPhaseScheduler, MinestomPhaseTask, MinestomEventRegistrar, MinestomEventListener) removed — Xerus phases handle scheduling internally without a separate PhaseScheduler - server: remove project(":shared:phase") dependency - plugins/game: delete old-style phase files (EndPhase, GamePhase, LobbyPhase, PreparationPhase, PhaseComponent, PhaseSystem, BukkitPhaseScheduler, BukkitEventRegistrar); strip phase references from ElytraRace, GameService, GameServiceImpl, DefaultListener - plugins/setup: delete BukkitPhaseScheduler and BukkitEventRegistrar (setup does not need a phase system); remove xerus dependency - settings.gradle.kts: remove include("shared:phase") - ArchUnit: drop shared_phase_must_not_use_minestom rule - CLAUDE.md: update module docs and Phase System section to reference Xerus
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared/phasemodule (net.elytrarace.api.phase.*) entirelyservermodule now uses Xerus 100% for the phase system; dead platform wrappers (MinestomPhaseScheduler,MinestomPhaseTask,MinestomEventRegistrar,MinestomEventListener) deleted — Xerus phases handle scheduling internallyplugins/setup:BukkitPhaseScheduler/BukkitEventRegistrardeleted (setup does not need a phase system)plugins/game(legacy): all old-style phase classes removed;SimplePhaseComponent/SimplePhaseSystemretained (self-contained, no external phase dependency)shared_phase_must_not_use_minestomrule removedCLAUDE.mdandsettings.gradle.ktsupdatedCloses #166
Notes
Xerus requires Java 25 and does not support Paper. For that reason
plugins/gameandplugins/setupdo not take a Xerus dependency — the setup plugin needs no phase system at all, andplugins/gameis a legacy module being replaced by theservermodule.Test plan
./gradlew buildpassesnet.elytrarace.api.phase.*plugins/setupin-game (no phase regression expected)🤖 Generated with Claude Code