Skip to content

fix(client): Improve api specification to avoid numbers in the client generation #20

Merged
theEvilReaper merged 5 commits intobetafrom
feature/improveApiDefinition
Aug 9, 2025
Merged

fix(client): Improve api specification to avoid numbers in the client generation #20
theEvilReaper merged 5 commits intobetafrom
feature/improveApiDefinition

Conversation

@theEvilReaper
Copy link
Contributor

Proposed changes

The pull request improves the open api specification to avoid numbers in the generated methods

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper merged commit 30cec06 into beta Aug 9, 2025
2 of 5 checks passed
@theEvilReaper theEvilReaper deleted the feature/improveApiDefinition branch August 9, 2025 13:33
theEvilReaper added a commit that referenced this pull request Oct 17, 2025
* feat(client): add OpenAPI generator configuration and push Dart client to repository

* fix(build): update paths for Dart client generation and improve Git command execution

* fix(build): streamline Git commands for client repository management

* feat(client): update Dart client package names and description for backend alignment

* Add response classes for the SoundEventEntity

* Add rest controller implementation for SoundEvents

* feat(service): implement SoundService for sound event management and refactor SoundController

* fix(client): Improve api specification to avoid numbers in the client generation  (#20)

* fix(attribute): Use operationId to improve attribute client generation

* fix(font): Use operationId to improve font client generation

* fix(item): Use operationId to improve item client generation

* fix(notification): Use operationId to improve notification client generation

* fix(sound): Use operationId to improve sound client generation

---------

Co-authored-by: theEvilReaper <theEvilReaper@users.noreply.github.com>

* refactor(model): Improve model class generation

* fix(deps): update vulpes.model version to 1.5.1 in settings.gradle.kts

* feat(release): enhance semantic release configuration to capture and store release version

* fix(release): update Dockerfile context path in semantic release configuration

* fix(release): update Dockerfile image path in semantic release configuration

* feat(deps): add PostgreSQL client dependency to build configuration

* feat(deps): add Micronaut management and Micrometer dependencies for Prometheus integration

* feat(deps): replace Log4j and SLF4J with Logback dependencies in build configuration

* fix(logging): update logback configuration to change log level and pattern

* fix(deps): update vulpes.model version to 1.5.1-beta.1 in settings

* feat(ci): add environment variables for Docker build process in semantic releases

* fix(build): update exec calls to use providers.exec for better compatibility

* feat(docker): add Docker Compose configuration for MariaDB service

* refactor(dtos): rename schema names to include 'Response' prefix for clarity

* feat(sound): implement pagination for sound sources and add SoundFileSourceDTO

* feat(sound): Add fixup for sounds integration (#24)

* fix(dependencies): update vulpes.model version to 1.6.0-beta.5

* feat(tests): add Faker library for enhanced JUnit test data generation

* feat(sound): add toEntity method in SoundFileSourceDTO for entity conversion

* feat(sound): enhance SoundService with methods for managing linked sound file sources

* feat(sound): add methods for creating, updating, and deleting linked sound sources

* feat(sound): add endpoints for managing linked SoundFileSources in SoundController

* feat(tests): add application-test.yml for test environment configuration

* feat(tests): add unit tests for SoundController methods

* feat(tests): add integration tests for SoundController endpoints

* feat(build): update author information and add publish URL in build.gradle.kts

* feat(sound): enhance API documentation for getSoundSourcesById endpoint

* feat(sound): rename schema name in SoundResponseDTO for clarity

* feat(notification): update schema name for clarity in NotificationModelErrorDTO

* feat(item): update schema name for clarity in ItemModelErrorDTO

* feat(sound): add error handling and documentation for add sound event endpoint

* feat(sound): update test to use sampleEventDTOWithoutId for sound event creation

* feat(tests): Rename test class

* feat(tests): Improve import handling

* feat(test): integrate Testcontainers for SoundController tests and update configuration

* feat(gitignore): add test-resources-port.txt to Docker ignore list

* feat(tests): remove unused import from SoundControllerIntegrationTest

* feat(ci): add QEMU and Docker Buildx setup to build pipeline

* feat(ci): update Docker setup action in build pipeline

* feat(ci): remove QEMU setup from build pipeline

* feat(tests): replace Testcontainers with EnabledIfDockerAvailable in SoundControllerIntegrationTest

* feat(ci): remove Docker setup from build pipeline

---------

Co-authored-by: theEvilReaper <theEvilReaper@users.noreply.github.com>

* feat(release): update publish command to include pushDartClient

* feat(build): streamline pushDartClient task by consolidating command execution

* feat(build): add force push to main branch in publish task

* feat(build): refactor pushDartClient task to use providers for command execution

* feat(build): update publish command to remove pushDartClient from execution

* fix(ci): Retrigger build

* feat(build): add git push command to publish task for main branch

* feat(api): update response schemas to use ArraySchema for multiple entities

* feat(build): add Flutter setup and build commands to the CI workflow

* feat(build): remove redundant Build Web step from CI workflow

* feat(build): comment out build_runner command in build.gradle.kts

* feat(build): comment out flutter pub get command in build.gradle.kts

* fix(FontController): handle null model case in getCharsById method (#30)

* fix(sound): Return page instead of a list when retrieving all SoundEvent models

* fix(test): Fix wrong method getAllSoundEvents signature

* fix(test): update testGetAll to validate paginated response structure

* fix: remove unnecessary @Valid annotation from get method (#38)

* fix(SoundController): remove unnecessary @Valid annotation from get method

* fix(SoundController): remove unnecessary @Valid annotation from source methods

* fix(settings): update vulpes.model version to 1.6.0-beta.9

* feat(ItemController): update enchantments, flags, and lore endpoints to support pagination

* feat(FontController): add endpoint to update characters of a font

* feat(ItemController): add endpoints to update enchantments, flags, and lore of an item

---------

Co-authored-by: Phillipp Glanz <6745190+TheMeinerLP@users.noreply.github.com>
Co-authored-by: theEvilReaper <theEvilReaper@users.noreply.github.com>
Co-authored-by: Phillipp Glanz <p.glanz@madfix.me>
theEvilReaper added a commit that referenced this pull request Mar 10, 2026
… generation (#20)

* fix(attribute): Use operationId to improve attribute client generation

* fix(font): Use operationId to improve font client generation

* fix(item): Use operationId to improve item client generation

* fix(notification): Use operationId to improve notification client generation

* fix(sound): Use operationId to improve sound client generation

---------

Co-authored-by: theEvilReaper <theEvilReaper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant