Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd16dd2951
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return | ||
| fi | ||
|
|
||
| printf '0.0.0.r%s.g%s\n' \ |
There was a problem hiding this comment.
Align ghfetch-rs-git fallback pkgver with automation
When no v* tags are present, this pkgver() fallback hardcodes 0.0.0, but scripts/compute-git-pkgver.sh falls back to the Cargo version (0.1.0 here). The automation in .github/workflows/aur-git.yml renders and publishes metadata using the script output, so AUR metadata can advertise 0.1.0.r... while end users building the package get 0.0.0.r..., creating inconsistent versioning and confusing update behavior.
Useful? React with 👍 / 👎.
What changed
ghfetch-rs-binandghfetch-rs-gitAUR package templates underpackaging/aur-binpackage onv*tags and refresh the-gitpackage frommainAUR_SSH_PRIVATE_KEYsecret in the READMEWhy
ghfetchis already taken in the AUR, so this uses theghfetch-rs-*names while still installing theghfetchexecutableValidation
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo test