Maintain: fix flaky test unit caused by enqueue not complete instantly #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinliu9508
force-pushed
the
flaky-test-enqueue-not-instant
branch
from
9dd81d2 to
7adb9ed
Compare
jinliu9508
force-pushed
the
flaky-test-enqueue-not-instant
branch
from
7adb9ed to
fa4c20a
Compare
jkasten2
requested changes
May 2, 2025
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
We shouldn't use delays and timeouts when it is feasible for tests. The root cause of this flaky test is going to be common, so let's invest in a better way to wait for the right event, instead of time based.
Contributor
Author
|
Replaced with this PR #2318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OperationRepo.enqueue() was changed to internal enqueue in a separate coroutine scope, we can no longer expect calling OperationRepo.enqueue() can instantly insert the operation. Adding a delay after each enqueue call in the unit test to give time for the internal enqueuing to actually complete.
This change is