Skip to content
This repository was archived by the owner on Oct 31, 2022. It is now read-only.

Updated to Android Gradle Plugin 4.0.2 and Gradle 6.6.1#139

Merged
jkasten2 merged 2 commits intomasterfrom
upgrade/apg_4.0.2_and_gradle_6.6.1
Oct 9, 2020
Merged

Updated to Android Gradle Plugin 4.0.2 and Gradle 6.6.1#139
jkasten2 merged 2 commits intomasterfrom
upgrade/apg_4.0.2_and_gradle_6.6.1

Conversation

@jkasten2
Copy link
Copy Markdown
Member

@jkasten2 jkasten2 commented Oct 9, 2020

No description provided.

@jkasten2 jkasten2 requested a review from Jeasmine October 9, 2020 19:18
Copy link
Copy Markdown

@Jeasmine Jeasmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but seems like travis is failing

@jkasten2
Copy link
Copy Markdown
Member Author

jkasten2 commented Oct 9, 2020

@Jeasmine It should be fixed after we get https://github.com/OneSignal/OneSignal-Gradle-Plugin/pull/137/commits merged in. It is due to a test where we have to manaul update the OneSiganl-Android-SDK version everytime we do an update

* `./gradlew wrapper --gradle-version=6.6.1 --distribution-type all`
@jkasten2 jkasten2 force-pushed the upgrade/apg_4.0.2_and_gradle_6.6.1 branch from 5018d98 to 32b2ef6 Compare October 9, 2020 20:38
@jkasten2 jkasten2 merged commit fbd2d85 into master Oct 9, 2020
@jkasten2 jkasten2 deleted the upgrade/apg_4.0.2_and_gradle_6.6.1 branch October 9, 2020 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants