[FIX] Initialized SDK twice if before RuntimeInitializeOnLoadMethod

[adamschlesinger]

Fixed

• Will no longer init SDK again if done before RuntimeInitializeOnLoadMethod

---

This change is 

[jkasten2]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @adamschlesinger, @iAmWillShepherd, and @shepherd-l)

---

com.onesignal.unity.android/Runtime/OneSignalAndroidInit.cs, line 37 at r1 (raw file):

    internal static class OneSignalAndroidInit {
        [RuntimeInitializeOnLoadMethod] public static void Init() {
            if (string.IsNullOrEmpty(OneSignal.AppId))

Why check if the AppId is null or empty instead of checking if OneSignal.Default is not null?

---

com.onesignal.unity.ios/Runtime/OneSignalIOSInit.cs, line 37 at r1 (raw file):

    internal static class OneSignalIOSInit {
        [RuntimeInitializeOnLoadMethod] public static void Init() {
            if (string.IsNullOrEmpty(OneSignal.AppId))

Why check if the AppId is null or empty instead of checking if OneSignal.Default is not null?

[adamschlesinger]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @iAmWillShepherd, @jkasten2, and @shepherd-l)

---

com.onesignal.unity.android/Runtime/OneSignalAndroidInit.cs, line 37 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Why check if the AppId is null or empty instead of checking if OneSignal.Default is not null?

That's primarily a result of the get/set methods inside Default. Realistically I could also simply remove both of these classes entirely which would also fix the issue. These are simply small optimizations.

---

com.onesignal.unity.ios/Runtime/OneSignalIOSInit.cs, line 37 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Why check if the AppId is null or empty instead of checking if OneSignal.Default is not null?

Ditto as above.

[jkasten2]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @iAmWillShepherd and @shepherd-l)