Skip to content

[FIX] il2cpp exception on NotificationPermissionChanged #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2022
Merged

[FIX] il2cpp exception on NotificationPermissionChanged #448

merged 5 commits into from
Feb 7, 2022

Conversation

@adamschlesinger
Copy link
Contributor

@adamschlesinger adamschlesinger commented Feb 4, 2022 •
edited by jkasten2
Loading

Fixed

  • iOS callbacks for the NotificationPermissionChanged event will no longer cause an il2cpp exception

Changed

  • Internal state mappings on iOS now rely on class defined objects over dynamic Dictionary types

This change is Reviewable

@adamschlesinger adamschlesinger requested a review from a team February 4, 2022 18:29
jkasten2
jkasten2 approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adamschlesinger)

jkasten2
jkasten2 approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adamschlesinger)

@adamschlesinger adamschlesinger force-pushed the feature/explicitBindings branch from 9b468a3 to 6892c69 Compare February 7, 2022 20:38
@adamschlesinger adamschlesinger merged commit b5b9a2e into develop Feb 7, 2022
@adamschlesinger adamschlesinger deleted the feature/explicitBindings branch February 7, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkasten2 jkasten2 jkasten2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamschlesinger @jkasten2