Skip to content

Conversation

@adamschlesinger
Copy link
Contributor

@adamschlesinger adamschlesinger commented Mar 10, 2022

Changed

  • Moved EDM4U installer step to the core package as it is needed for both platforms

This change is Reviewable

@adamschlesinger adamschlesinger requested a review from a team March 10, 2022 17:02
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adamschlesinger)

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adamschlesinger)

@adamschlesinger adamschlesinger merged commit 57eb0f1 into develop Mar 10, 2022
@adamschlesinger adamschlesinger deleted the fix/edm4u branch March 10, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants