Skip to content

Update spec to be a more closer representation of the server responses#9

Merged
kesheshyan merged 2 commits intomainfrom
api-alignment
May 10, 2022
Merged

Update spec to be a more closer representation of the server responses#9
kesheshyan merged 2 commits intomainfrom
api-alignment

Conversation

@brismithers
Copy link
Copy Markdown
Contributor

The following changes were made to the spec, to be more closely aligned with what the OneSignal REST API is returning:

  • Add nullable to properties which may be null. I do not believe this is an exhaustive list, but are ones that I immediately identified as fields that could be null.
  • No longer require properties that are not always returned by the server. Some models are used in more than one endpoint, a property's "required-ness" can depend on the endpoint. When this is the case, I removed the required attribute from these properties to support proper serialization/deserialization within the server SDKs.
  • Add more accurate data types/formats.

of the server responses:
- Add nullable to properties which can be null.
- No longer require properties that are not always
  returned by the server.
- Add more accurate data types/formats.
@brismithers brismithers requested a review from kesheshyan May 10, 2022 18:19
@kesheshyan kesheshyan merged commit 9934a10 into main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants