Conversation
jkasten2
requested changes
Nov 29, 2021
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @emawby and @Jeasmine)
README.md, line 11 at r1 (raw file):
2. If you do not have bundler 2 installed run `gem install bundler` 3. Run `bin/bundle install` from the root directory of the repository 4. Commands can be run via `bin/onesignal <command>` from the root of the repository
This should be updated as well.
README.md, line 16 at r1 (raw file):
* `bin/onesignal help` Lists the available commands in the OneSignal CLI * `bin/onesignal install-sdk` Install the OneSignal SDK in the project
This should be updated as well.
Jeasmine
force-pushed
the
main
branch
18 times, most recently
from
cc536af to
a0f7f02
Compare
Add options to example usage Add calling directory specification Update installation steps
Jeasmine
force-pushed
the
improvement/update-readme
branch
from
40fad6f to
dabb800
Compare
jmadler
approved these changes
Jan 4, 2022
Contributor
jmadler
left a comment
jmadler
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @emawby, @Jeasmine, and @jkasten2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add options to example usage
Add calling directory specification
This change is