sync with web-shim-codegen v3.0.2 #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Export OneSignal types and interfaces (OneSignal/web-shim-codegen@b3143a0)
sherwinski
approved these changes
Mar 24, 2025
Contributor
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tkhquang
reviewed
Mar 27, 2025
Comment on lines
-24
to
+28
| "node": ">=8", | ||
| "npm": ">=5" | ||
| "node": ">=22", | ||
| "npm": ">=10" |
There was a problem hiding this comment.
Hi @fadi-george @sherwinski , any reason for this sudden change? This version is not flagged as breaking change but this alone causes a lot of trouble when upgrading, for example, from 3.0 to 3.2
[2/4] 🚚 Fetching packages...
error react-onesignal@3.2.0: The engine "node" is incompatible with this module. Expected version ">=22". Got "20.17.0"
Node 20 is still in maintenance and it should be supported
Collaborator
There was a problem hiding this comment.
@tkhquang Sorry for that, will push a change to lower the range to 14.
Contributor
There was a problem hiding this comment.
Hey @tkhquang, thanks for pointing that out. Agreed that the range shouldn't be bumped so aggressively - we'll patch a fix for it soon.
Collaborator
There was a problem hiding this comment.
3.2.1 a fix to the node engines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes