feat: add Vue 2/3 and Angular example apps#136
Merged
Conversation
sherwinski
reviewed
May 18, 2026
Contributor
sherwinski
left a comment
sherwinski
left a comment
There was a problem hiding this comment.
We exclude bun.lock in copy-build-to-outputs.sh but we're still committing them in this repo. I think we should be consistent one way or another.
sherwinski
approved these changes
May 18, 2026
Generated bun.lock files for the Vue 2, Vue 3, and Angular examples under src/static so they survive the build/copy pipeline (rsync --delete was wiping the empty example dirs otherwise). Refreshed the React example lockfile and the downstream outputs/ snapshots so everything is in sync with the current package.json files. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add modern Vite-based example apps for Vue 2, Vue 3, and Angular alongside the existing React example, standardize the per-example setup flow, and switch all dev servers to port 4000 with locally-trusted HTTPS.
Details
src/static/vue/v2/example/,src/static/vue/v3/example/, andsrc/static/onesignal-ngx/example/apps following the same shape as the React examplescripts/setup.shacross React/Vue/Angular: pack the parent SDK as a fixed-name tarball and install it viavp install --forceto avoid duplicatepackage.jsonentriesvite-plugin-mkcert, and for Angular via ascripts/start.shwrapper that uses mkcert certs when available (and falls back to Angular's self-signed cert otherwise)bun.lockfrom the rsync excludes inscripts/copy-build-to-outputs.shso the script stays consistent with the lockfiles committed underoutputs/Testing
I tested all four examples end-to-end and confirmed each one builds, installs the freshly packed parent SDK, serves on
localhost:4000over HTTPS, and loads OneSignal without errors.Made with Cursor