fix(monitor): clean per-session Maps on signal shutdown (#1115)#1255
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: signal-cleanup-helper.ts called
sessions.killSessionbut did NOT callcleanupTerminatedSessionState. When SIGTERM/SIGINT fired, all monitor/metrics/toolRegistry per-session Maps accumulated stale entries — memory leak.Fix:
SessionCleanupDepsparameter tokillAllSessionsandkillAllSessionsWithTimeoutin signal-cleanup-helper.tskillSession, callcleanupTerminatedSessionStateif deps providedserver.tsshutdown path to pass{ monitor, metrics, toolRegistry }Note:
removeSession(monitor cleanup) was already comprehensive — the issue was that it was never called in the signal shutdown path.Developed with Aegis v0.1.0-alpha
Refs: #1115