fix(dashboard): CalendarGrid format patterns + test locale mismatch#4532
Merged
Conversation
Owner
Author
|
Closing as duplicate — CalendarGrid fix already included in #4531 by Hephaestus. |
OneStepAt4time
pushed a commit
that referenced
this pull request
May 31, 2026
- Add EEEE, EEE, d patterns to native Date format helper
- Fixes aria-label producing literal 'EEEE, June d, 2026'
- Fix test locale mismatch: toLocaleDateString('en-US') -> toLocaleString('en')
- 9/9 CalendarGrid tests pass
Closes #4532
OneStepAt4time
force-pushed
the
fix/calendar-grid-format-patterns
branch
from
9de191c to
44f147d
Compare
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Approved.
Review summary:
- Clean 2-file fix for CalendarGrid format patterns
- Adds missing
d,EEEE,EEEtokens to format helper - Fixes root cause: aria-label was producing literal "EEEE, June d, 2026"
- No scope creep (docs drafts removed)
- Security clean — safe locale usage
- Add EEEE, EEE, d patterns to native Date format helper
- Fixes aria-label producing literal 'EEEE, June d, 2026'
- Fix test locale mismatch: toLocaleDateString('en-US') -> toLocaleString('en')
- 9/9 CalendarGrid tests pass
Closes #4532
OneStepAt4time
force-pushed
the
fix/calendar-grid-format-patterns
branch
from
44f147d to
45ddd0d
Compare
OneStepAt4time
pushed a commit
that referenced
this pull request
May 31, 2026
OneStepAt4time
force-pushed
the
fix/calendar-grid-format-patterns
branch
2 times, most recently
from
aaf6fb6 to
45ddd0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CalendarGrid e2e test failure blocking #4531 merge.
Changes:
Verification:
Unblocks #4531 CI.