fix(#4526): add unregister method to InMemoryRunnerRegistry#4548
Merged
Conversation
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Registry unregister changes are clean and correct — interface addition, implementation with default promotion, and 3 good test cases. ✅
However, this PR includes duplicate changes from #4528 (timeoutMs fallback in cc-agents-discovery.ts) which was already merged in #4547. Please rebase #4548 on latest develop to remove the redundant cc-agents-discovery.ts changes so the diff contains only the registry work. 👁️
- Add unregister(name) to RunnerRegistry interface - Implement unregister in InMemoryRunnerRegistry: - Removes runner from internal Map - If removed runner was default, promotes next registered runner - If no runners remain, getDefault throws as before - Add 3 unit tests for unregister behavior Closes #4526
OneStepAt4time
force-pushed
the
fix/4526-registry-unregister
branch
from
b066ee2 to
ad008e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4526
Summary
The InMemoryRunnerRegistry had no way to remove a registered runner. This adds an unregister method to both the interface and implementation.
Changes
unregister(name: string): voidtoRunnerRegistryinterfaceunregisterinInMemoryRunnerRegistry:getDefaultcontinues to throw as beforeVerification