fix(dashboard): use scrim tokens in modal backdrops (#4578)#4589
Closed
OneStepAt4time wants to merge 1 commit into
Closed
fix(dashboard): use scrim tokens in modal backdrops (#4578)#4589OneStepAt4time wants to merge 1 commit into
OneStepAt4time wants to merge 1 commit into
Conversation
Path B slice 9 of #4578 — applies the new scrim design token (added in #4577) to 3 modal backdrops. Files changed (3): - CreateSessionModal.tsx:207 — backdrop - CreatePipelineModal.tsx:121 — backdrop - TemplateModal.tsx:152 — backdrop Token mapping (from #4577): - bg-black/60 (3) → bg-[color:var(--color-scrim)] All three backdrops are identical pattern: `absolute inset-0 bg-black/60 backdrop-blur-sm`. The new --color-scrim token is defined as `black/60` in dark theme and `black/50` in light/light-paper/light-aaa (slight reduction for better contrast against lighter surfaces — see #4577 for rationale). Verification: - tsc --noEmit: clean (3 pre-existing chartTheme/logger errors are unrelated, present on develop HEAD) - vitest run: 224 files, 2252 tests pass, 2 skipped - vite build: clean (2.72s) Out of scope (deferred): - FirstRunTour.tsx:246 — bg-black/80 (heavier scrim, no matching token) - SessionDetailPage.tsx:292 — bg-black/40 (lighter scrim, no matching token) - SettingsPage, SessionHistoryPage, SessionsPage, NewSessionDrawer, Layout (raw border-white and bg-white matches covered by future slices)
Owner
Author
|
Closing as redundant. PR #4579 ( Real next-slice candidates after the 7-batch lands: SettingsPage (1 match) plus any leftover lines in the 7-batch's files. — Daedalus 🏛️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Slice 9 of #4578 — converts 3 modal backdrops from raw
bg-black/60to the--color-scrimdesign token (added in #4577).All three backdrops are the identical pattern
absolute inset-0 bg-black/60 backdrop-blur-sm. The new--color-scrimtoken is defined asblack/60in dark theme, with theme variants in light/light-paper/light-aaa (slight reduction toblack/50for better contrast on lighter surfaces — see #4577 for rationale).Verification
tsc --noEmit— clean (3 pre-existing errors in chartTheme.tsx/logger.ts are unrelated, present on develop HEAD)vitest run— 224 files, 2252 tests pass, 2 skipped (~172s)vite build— clean (2.72s)grep -rE 'text-white|bg-black|border-white' dashboard/src/— matches in the 3 changed files removed (1 match each eliminated)Token mapping (from #4577)
bg-black/60(3) →bg-[color:var(--color-scrim)]Out of scope (deferred to future slices)
FirstRunTour.tsx:246—bg-black/80(heavier scrim, no matching token — would need a new--color-scrim-heavyvariant)SessionDetailPage.tsx:292—bg-black/40(lighter scrim, no matching token — would need a new--color-scrim-lightvariant)SettingsPage,SessionHistoryPage,SessionsPage,NewSessionDrawer,Layout— remaining border-white and bg-white matches for future Path B slicesLane: Daedalus (per #4578). Not blocking Hermes, Argus, Scribe, Hep, or any P0/P1 work.
🤖 Generated with Claude Code