[pull] release from appsmithorg:release#484
Merged
pull[bot] merged 2 commits intoOneToolsCollection:releasefrom May 14, 2025
Merged
[pull] release from appsmithorg:release#484pull[bot] merged 2 commits intoOneToolsCollection:releasefrom
pull[bot] merged 2 commits intoOneToolsCollection:releasefrom
Conversation
…om search results (#40647) ## Description <ins>Problem</ins> Table search results included irrelevant search results. <ins>Root cause</ins> System columns were not excluded in the search logic, causing them to be considered during filtering. <ins>Solution</ins> This PR handles the exclusion of system columns from the table search logic, ensuring only relevant user-visible columns are considered during filtering. This improves the accuracy and clarity of search results. Fixes #39469 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/15011289429> > Commit: 0ca8bca > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=15011289429&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table` > Spec: > <hr>Wed, 14 May 2025 03:41:27 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved search functionality in tables by excluding system columns from search results, ensuring more accurate filtering. - **Tests** - Added and reorganized tests to validate search behavior, focusing on exclusion of system and hidden columns from search results. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…hen infinite scroll is enabled. (#40632) ## Description <ins>Problem</ins> Table failed to load data for a page when network or query failures occurred with infinite scroll enabled. <ins>Root cause</ins> There was no fallback or handling mechanism for offline scenarios or query failures, causing the table to enter an unusable state. <ins>Solution</ins> This PR handles enhancing offline data handling for the table when infinite scroll is enabled. We ensure that a data fetch request for the next page is triggered regardless of the scenario. * For example, if we are on page 2 and attempt to navigate to page 3, but the network request fails due to being offline or a timeout, we recognize that we lack data for page 3. If the user reverse scrolls and then resumes scrolling toward page 3, we will issue a new request. * This process relies on accurately tracking the current page and the user's scrolling intent, while also checking the data we have already received. Fixes #40579 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/15011754024> > Commit: 9c48e7c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=15011754024&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table` > Spec: > <hr>Wed, 14 May 2025 04:22:05 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Improved infinite scroll in tables with enhanced data caching, reducing redundant data requests and improving performance during pagination. - Table components now leverage cached data for smoother scrolling and more efficient page loading. - **Performance** - Optimized table rendering to prevent unnecessary re-renders when cached data remains unchanged. - **Bug Fixes** - Prevented updates to end-of-data status when offline, avoiding incorrect data state during connectivity issues. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )