Add "TotalPages" into the exported components #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "TotalPages" component into the components export
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 89c639b in 19 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/components/index.tsx:77
- Draft comment:
Ensure that theTotalPagescomponent is correctly implemented and tested in theControls/PageNumbermodule to avoid runtime errors. - Reason this comment was not posted:
Confidence changes required:50%
The PR correctly adds TotalPages to the export list, which matches the import statement and usage in the Example component.
Workflow ID: wflow_5y4XMZiVKJJPjFmC
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
Author
|
Hi ! |
Titou325
approved these changes
Nov 9, 2024
Member
|
Thank you very much for your contribution! Just merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "TotalPages" component into the components export
Important
Add
TotalPagesto the export list inindex.tsx.TotalPagesto the export list inindex.tsxfor external use.This description was created by
for 89c639b. It will automatically update as commits are pushed.