Skip to content

Conversation

@ian-oneleet
Copy link
Contributor

@ian-oneleet ian-oneleet commented Sep 25, 2025

Problem

https://linear.app/oneleet/issue/ENG-3372/modx-allow-ignoring-digitalocean-droplets-with-tags-like-for-aws

We haven't documented this yet.

Solution

Add a very brief note to a new DigitalOcean docs page.

Summary by CodeRabbit

  • New Features
    • DigitalOcean now appears in the Integrations list with a proper display name.
  • Documentation
    • Added a DigitalOcean integration guide, including steps to manage visibility of resources.
    • Note: To exclude specific droplets from Oneleet counts, tag them with oneleet-ignore.

@ian-oneleet ian-oneleet requested a review from xplato September 25, 2025 14:38
@vercel
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
oneleet-docs Ready Ready Preview Comment Sep 25, 2025 2:40pm

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

Added a DigitalOcean entry to the integrations metadata and introduced a new documentation page detailing the DigitalOcean integration and how to ignore droplets via a specific tag.

Changes

Cohort / File(s) Summary
Integration metadata update
pages/integrations/_meta.ts
Added digitalocean: "DigitalOcean" to the default export mapping of integration display names.
Docs — DigitalOcean integration guide
pages/integrations/digitalocean.mdx
New MDX page with front matter and guidance on tagging droplets with oneleet-ignore to exclude them from counts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

In clouds I hop with gentle cheer,
A droplet’s name now crystal clear.
Tag it swift—oneleet-ignore—
And counts won’t see it any more.
DigitalOcean joins the lore—
Thump-thump! I’m off to scan for more. 🐇🌊

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description provides the Problem and Solution sections but omits the required Testing section and its checkboxes for unit, integration, and manual tests as specified by the repository’s template. Please add a “## Testing” section with checkboxes for unit tests, integration tests, and manual tests to conform to the repository’s pull request description template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely summarizes the primary change by indicating documentation of the oneleet-ignore tag for DigitalOcean and includes the relevant issue identifier, which aligns directly with the modifications in both code mapping and new documentation content.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ian/digitalocean-ignore

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 2382502 and 758be3a.

📒 Files selected for processing (2)
  • pages/integrations/_meta.ts (1 hunks)
  • pages/integrations/digitalocean.mdx (1 hunks)
🔇 Additional comments (2)
pages/integrations/_meta.ts (1)

5-5: DigitalOcean entry looks good.

Thanks for rounding out the integrations map with the DigitalOcean label—matches the new docs addition.

pages/integrations/digitalocean.mdx (1)

1-10: Clear guidance on ignoring droplets.

Straightforward doc addition with the necessary tag instructions—reads cleanly and covers the use case.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ian-oneleet ian-oneleet merged commit 4fb93c5 into main Sep 26, 2025
4 checks passed
@ian-oneleet ian-oneleet deleted the ian/digitalocean-ignore branch September 26, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants