Feature/ode 57 create info service #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duynguyenod
requested changes
Dec 25, 2019
duynguyenod
left a comment
duynguyenod
left a comment
There was a problem hiding this comment.
Merge vào integration, không phải master, chưa rebase
enpopo2101
force-pushed
the
feature/ODE-57-Create-Info-service
branch
from
d47bd11 to
f4e8206
Compare
duynguyenod
requested changes
Dec 25, 2019
duynguyenod
left a comment
duynguyenod
left a comment
There was a problem hiding this comment.
Toàn bộ test em viết đang là integration test, vì nó có can thiệp đến model.
Unit test em phải mock cái model nha. Add thêm nhá, mấy cái exist thì vẫn là unit test.
Những task khác, nếu có integration test thì tốt nhưng không bắt buôcj, có thể thêm sau, nhưng unit test là phải có nha e.
|
Em có thể coi những file khác trong unit test để tham khảo nha |
duynguyenod
reviewed
Dec 26, 2019
duynguyenod
reviewed
Dec 26, 2019
duynguyenod
reviewed
Dec 26, 2019
src/services/info.service.js
Outdated
| import { assignIn } from 'lodash'; | ||
| import InfoModel from '../models/info.model'; | ||
|
|
||
| exports.create = async (any) => { |
There was a problem hiding this comment.
Nếu như input data là any thì e đã test vs trường hợp {
key: 'ahihi',
balabbaxam: ''
}
Như này thì nó vẫn có lỗi ko?
Contributor
Author
There was a problem hiding this comment.
cái này sẽ không có lỗi ạ, chỉ ko lưu cái kia vào thôi a
duynguyenod
reviewed
Dec 26, 2019
duynguyenod
requested changes
Jan 2, 2020
duynguyenod
force-pushed
the
feature/ODE-57-Create-Info-service
branch
from
d53e514 to
d3ecf0c
Compare
enpopo2101
force-pushed
the
feature/ODE-57-Create-Info-service
branch
from
d3ecf0c to
5a8b6fc
Compare
change folder fix path import add test add more test edit some problems edit test edit test update test
duynguyenod
force-pushed
the
feature/ODE-57-Create-Info-service
branch
from
5a8b6fc to
d036954
Compare
duynguyenod
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.