Fix npm trusted publishing release runner#91
Merged
Conversation
64e2243 to
8150b47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The merged 0.6.0 release PR (#89) failed during
npm publish; npm still reports@ontos-ai/knowhere-sdklatest as 0.5.0. The release workflow already grantsid-token: writeand installs npm 11.5.2+, but npm trusted publishing currently requires Node 22.14.0+.This PR makes the repo-side release runner compatible with npm trusted publishing so merging it should let the next main-branch Release Management run publish the already-versioned 0.6.0 package. If npm trusted publishing is not configured for this package/workflow, the remaining blocker is npm package settings or the npm token's org/package permissions.
Official npm docs: https://docs.npmjs.com/trusted-publishers/
Verification
npm cinpm run release:check-changeset -- origin/mainnpm run format:checknpm run typechecknpm run lintnpm run test:cinpm run buildgit diff --check