Skip to content

Fix mobile chunk title badge radius#20

Merged
suguanYang merged 1 commit into
stagingfrom
fix/mobile-chunk-title-badge
May 10, 2026
Merged

Fix mobile chunk title badge radius#20
suguanYang merged 1 commit into
stagingfrom
fix/mobile-chunk-title-badge

Conversation

@suguanYang
Copy link
Copy Markdown
Contributor

@suguanYang suguanYang commented May 10, 2026

Summary

  • Change parsed chunk title badges from rounded-full to rounded-lg so wrapped titles do not render as oversized pills.
  • Apply the same less-rounded treatment to chat “Sources used” parsed chunk links, which are another user-visible parsed chunk title path.
  • Preserve the existing badge/link width and display layout while enabling horizontal scrolling on the chunks panel ScrollArea.
  • Rebase onto latest staging after PR Optimize notebook chunk and chat lists #19 landed, preserving the virtualized chunk list viewportRef/scroll handler behavior.
  • Fix citation jumps into virtualized chunk lists by always including the currently focused chunk row in the virtual range, so clicked citations can mount and scroll to targets outside the initial render window.
  • Align focused citation jumps to the start of the chunk row so long table chunks open with their title/header visible instead of centered midway through the table.
  • Add regression tests for the radius-only chunk title fix, the chat source-link title fix, the Radix viewport overflow-x: scroll behavior, and focused citation targets outside the initial virtual range.

Verification

  • pnpm test src/components/chunks-panel.test.ts
  • pnpm test src/components/chat-panel.test.ts
  • pnpm test src/components/workspace-shell.test.ts
  • pnpm test
  • pnpm exec tsc --noEmit
  • pnpm lint
  • pnpm build
  • git diff --check
  • Real browser mobile check with Chrome DevTools at 390x844: clicked a TSLA demo citation to table-13; after the fix the focused row landed about 12px below the chunks viewport top.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment May 10, 2026 5:54am

Request Review

@suguanYang suguanYang force-pushed the fix/mobile-chunk-title-badge branch from 3d01f93 to 36fbfc2 Compare May 10, 2026 05:02
@suguanYang suguanYang changed the title Fix mobile chunk title badge wrapping Fix mobile chunk title badge radius May 10, 2026
@suguanYang suguanYang force-pushed the fix/mobile-chunk-title-badge branch from 36fbfc2 to ae6736e Compare May 10, 2026 05:15
@suguanYang suguanYang force-pushed the fix/mobile-chunk-title-badge branch from ae6736e to df93631 Compare May 10, 2026 05:24
@suguanYang suguanYang force-pushed the fix/mobile-chunk-title-badge branch from df93631 to 3d4f34b Compare May 10, 2026 05:38
@suguanYang suguanYang force-pushed the fix/mobile-chunk-title-badge branch from 3d4f34b to 2f186c1 Compare May 10, 2026 05:53
@suguanYang suguanYang merged commit bffb58a into staging May 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant