Skip to content

Fix citation focus positioning#26

Merged
suguanYang merged 1 commit into
stagingfrom
fix/citation-focus-position
May 10, 2026
Merged

Fix citation focus positioning#26
suguanYang merged 1 commit into
stagingfrom
fix/citation-focus-position

Conversation

@suguanYang
Copy link
Copy Markdown
Contributor

Summary

  • Re-apply the focused citation chunk scroll reset on the next animation frame so TanStack Virtual/browser layout measurement cannot leave the viewport offset below the focused chunk.
  • Add a regression test that simulates a tall focused table chunk being moved to row 0, then a post-layout scroll adjustment that must be reset back to the start.

Verification

  • pnpm test src/components/chunks-panel.test.ts -- --runInBand
  • pnpm test
  • pnpm exec tsc --noEmit
  • pnpm lint
  • pnpm build
  • git diff --check
  • Browser sanity check on http://localhost:3027: guest chunks render with measured row heights and no table-row overlap after reload.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment May 10, 2026 9:18am

Request Review

@suguanYang suguanYang merged commit 9ee77f4 into staging May 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant