Fix/wangbinqi/concise error summary

[suguanYang]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
knowhere-notebook-staging	Ready	Preview, Comment	May 17, 2026 9:04am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
knowhere-notebook	Ignored	Preview	May 17, 2026 9:04am

[suguanYang]

Review finding:

• P2: src/components/chat-message-list.tsx:291 deduplicates citations only by rendered label. Source titles are not unique in the sources schema, so two different documents with the same uploaded filename/title produce the same label and the second citation is dropped. The answer then hides a real source and cannot open it, even though its documentId is different. Please deduplicate by a stable source/citation identity, or disambiguate duplicate labels, instead of using display text alone.

[suguanYang]

Fixed in 48ddd58: citation display dedupe now keys on source identity plus label, so repeated citations from the same source still collapse but distinct documents with the same rendered label remain separately clickable. Added regression coverage for two different documents named report.pdf.

Verification:

• pnpm test src/components/workspace-citation-focus.test.ts src/components/workspace-citation-state.test.ts src/components/chat-panel.test.ts src/components/chat-message-list.test.ts src/components/parsed-chunk-card.test.ts src/app/page.test.ts src/lib/effect-operation.test.ts
• pnpm typecheck
• pnpm lint
• git diff --check origin/staging...HEAD

[suguanYang]

Follow-up pushed in 11a8735 adds Playwright coverage for duplicate citation source labels. The browser test renders a real workspace shell with two distinct sources that share the same visible title, verifies both citation buttons remain visible, and confirms the second button opens the second source's chunks.

Verification:

• PLAYWRIGHT_EXTERNAL_WEB_SERVER=1 pnpm exec playwright test e2e/citation-dedupe.e2e.ts --project=chromium
• pnpm test src/components/chat-panel.test.ts src/components/chat-message-list.test.ts
• pnpm typecheck
• pnpm lint
• git diff --check && git diff --cached --check

GitHub CI, CodeQL, and Vercel checks are green on the latest head.