Priority 1 dev#16
Conversation
typo in the xsd.
… priority_1_dev
There was a problem hiding this comment.
Pull request overview
This PR adds new XML example files, clarifies XSD documentation descriptions, and updates the project file to reference new/renamed schema files and examples.
Changes:
- Improved XSD documentation in
opra_statistics_support.xsdwith clearer numerator/denominator descriptions - Added new example XML files:
PlannedFleetDimensions.xml,PlannedCapacityIndicator.xml, andCancelledDatedVehicleJourneys.xml - Updated
OpRa.xprto reference renamed/new schema files and the new example
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| xsd/opra_framework/opra_reusableComponents/opra_statistics_support.xsd | Clarified group and element documentation with numerator/denominator terminology |
| examples/PlannedFleetDimensions.xml | New example for planned fleet dimensions for a line and operating day |
| examples/PlannedCapacityIndicator.xml | New example for planned capacity indicator across line and journey pattern |
| examples/CancelledDatedVehicleJourneys.xml | New example for cancelled dated vehicle journeys with occurrence statistics |
| OpRa.xpr | Added new example and schema file references, replaced renamed schema entries |
| OJP | Updated submodule commit reference |
| NeTEx | Updated submodule commit reference |
| .gitignore | Added .tmp and docs to ignored paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <netex:OperatingDayRef ref="Test:OperatingDay:2026-03-01"/> | ||
| <netex:VehicleTypeRef ref="Test:VT:bus:regular"/> | ||
| <RollingStockType>selfPropelled</RollingStockType> | ||
| <NumberOfVehiclesTotal>24</NumberOfVehiclesTotal> |
There was a problem hiding this comment.
The numbers appear internally inconsistent: NumberOfVehiclesRequired (20) + NumberOfVehiclesInReserve (2) = 22, which does not equal NumberOfVehiclesTotal (24). Additionally, NumberOfVehiclesAvailable (22) equals Required + Reserve but not Total. If NumberOfVehiclesAvailable is intended to be Total minus some unavailable vehicles, the values should add up correctly. Reviewers/consumers of this example may be confused by values that don't reconcile. Consider aligning these numbers so they reflect a coherent scenario (e.g., Total=24, Available=22, Required=20, InReserve=2, and clarify that 2 of the 24 are unavailable).
| <NumberOfVehiclesTotal>24</NumberOfVehiclesTotal> | |
| <NumberOfVehiclesTotal>22</NumberOfVehiclesTotal> |
| <netex:JourneyPatternRef ref="Test:JP:10:T1-T3a"/> | ||
| <!-- Numerator: journeys cancelled in the scope above --> | ||
| <NumberOfOccurrences>2</NumberOfOccurrences> | ||
| <PercentageOfOccurrences>0.0270</PercentageOfOccurrences> |
There was a problem hiding this comment.
The percentage value 0.0270 does not match the numerator/denominator values given: 2 cancelled out of 74 total journeys = 2/74 ≈ 0.02703, which as a percentage would be approximately 2.703 (if expressed as a percentage, i.e. 0–100 scale) or 0.02703 (if expressed as a decimal proportion, i.e. 0–1 scale). If PercentageType uses a 0–100 scale, the value should be approximately 2.703 rather than 0.0270. Please verify the expected scale of PercentageType and correct the value accordingly.
| <PercentageOfOccurrences>0.0270</PercentageOfOccurrences> | |
| <PercentageOfOccurrences>2.703</PercentageOfOccurrences> |
some new examples, some typos fixed in xsd (descriptions).