Conversation
added 5 commits
December 26, 2024 10:19
je-foster
reviewed
Jan 3, 2025
Contributor
There was a problem hiding this comment.
Please revert these changes.
je-foster
reviewed
Jan 3, 2025
Contributor
There was a problem hiding this comment.
Change to match new loop timers.
je-foster
reviewed
Jan 3, 2025
src/TankController.cpp
Outdated
| unsigned long thisTime = millis(); | ||
| if (report_loop_delay && lastTime && thisTime - lastTime > 500) { | ||
| // report unusual delay | ||
| serial(F("unexpected delay of %i ms"), thisTime - lastTime); |
Contributor
There was a problem hiding this comment.
I think it would be clearer to measure the difference between currentLoopStart and previousLoopStop
Contributor
There was a problem hiding this comment.
This would also be a good place to measure and report the difference between currentLoopStart and previousLoopStart
je-foster
reviewed
Jan 3, 2025
| serial(F("TankController::loop() - took %lu ms (at %lu sec uptime)"), loopTime, start / 1000); | ||
| } | ||
| lastTime = millis(); | ||
| } |
Contributor
There was a problem hiding this comment.
Here, just set previousLoopStop to millis() ("previous" isn't quite right, but it's about to be previous)
je-foster
requested changes
Jan 3, 2025
Contributor
je-foster
left a comment
je-foster
left a comment
There was a problem hiding this comment.
See comments regarding loop delay timers (and its test) and the sine amplitude being nonzero.
added 2 commits
January 6, 2025 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.