Skip to content

packchk: add validation for <csolution> element #2007 (#1182)#2012

Merged
edriouk merged 1 commit intoOpen-CMSIS-Pack:mainfrom
ARM-software:outbound/validateCsolutionElement_2007
Mar 6, 2025
Merged

packchk: add validation for <csolution> element #2007 (#1182)#2012
edriouk merged 1 commit intoOpen-CMSIS-Pack:mainfrom
ARM-software:outbound/validateCsolutionElement_2007

Conversation

@grasci-arm
Copy link
Copy Markdown
Collaborator

No description provided.

@thorstendb-ARM thorstendb-ARM requested a review from edriouk March 6, 2025 07:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2025

Test Results

  6 files   12 suites   10s ⏱️
 48 tests  48 ✅ 0 💤 0 ❌
144 runs  144 ✅ 0 💤 0 ❌

Results for commit da94ca7.

@edriouk edriouk merged commit 2d98cdb into Open-CMSIS-Pack:main Mar 6, 2025
@edriouk edriouk deleted the outbound/validateCsolutionElement_2007 branch March 6, 2025 08:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 87.36842% with 12 lines in your changes missing coverage. Please review.

Project coverage is 66.02%. Comparing base (17cd695) to head (da94ca7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/packchk/src/CheckFiles.cpp 89.06% 3 Missing and 4 partials ⚠️
.../packchk/test/integtests/src/PackChkIntegTests.cpp 83.87% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2012      +/-   ##
==========================================
+ Coverage   65.91%   66.02%   +0.10%     
==========================================
  Files         173      173              
  Lines       35851    35945      +94     
  Branches    20848    20894      +46     
==========================================
+ Hits        23631    23731     +100     
+ Misses       7902     7892      -10     
- Partials     4318     4322       +4     
Flag Coverage Δ
packchk-cov 70.70% <87.36%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/packchk/include/CheckFiles.h 100.00% <ø> (ø)
.../packchk/test/integtests/src/PackChkIntegTests.cpp 71.22% <83.87%> (+0.53%) ⬆️
tools/packchk/src/CheckFiles.cpp 74.22% <89.06%> (+2.11%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants