Add STAC 1.1 bands support to load_stac metadata guessing #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
force-pushed
the
issue699-stac11-band-support
branch
from
7d82278 to
1bbfeed
Compare
soxofaan
commented
Jun 5, 2025
based on implementation from Open-EO/openeo-geopyspark-driver#1213
to resolve lint issue about unresolved name
and unit test coverage
soxofaan
force-pushed
the
issue699-stac11-band-support
branch
from
3b7212d to
2d42695
Compare
soxofaan
commented
Jun 17, 2025
This was
linked to
issues
Jun 17, 2025
Support for STAC 1.1 item_assets through `Collection.item_assets` is only available since 1.12. Below that DIY dict handling is necessary.
soxofaan
force-pushed
the
issue699-stac11-band-support
branch
from
3c773d1 to
6d5c5ad
Compare
soxofaan
commented
Jun 17, 2025
openeo/metadata.py
Outdated
| return TemporalDimension(name=name, extent=extent) | ||
|
|
||
| def _band_from_eo_bands_metadata(self, band: Union[dict, pystac.extensions.eo.Band]) -> Band: | ||
| """Construct band from metadata dict in eo v1.1 style""" |
Member
Author
There was a problem hiding this comment.
Suggested change
| """Construct band from metadata dict in eo v1.1 style""" | |
| """Construct band from metadata in eo v1.1 style""" |
openeo/metadata.py
Outdated
| return bands | ||
|
|
||
| # TODO: instead of warning: exception, or return None? | ||
| self._warn("bands_from_stac_item: no band name source found") |
Member
Author
There was a problem hiding this comment.
TODO: way to suppress this warning when traversing a deeper hierarchy?
openeo/metadata.py
Outdated
| return _BandList(self._band_from_common_bands_metadata(b) for b in asset.extra_fields["bands"]) | ||
|
|
||
| # TODO: instead of warning: exception, or return None? | ||
| self._warn("bands_from_stac_asset: no band name source found") |
Member
Author
There was a problem hiding this comment.
way to suppress warning when traversing
soxofaan
added a commit
that referenced
this pull request
Jun 18, 2025
soxofaan
added a commit
that referenced
this pull request
Jun 18, 2025
soxofaan
added a commit
that referenced
this pull request
Jun 18, 2025
soxofaan
added a commit
that referenced
this pull request
Jun 18, 2025
soxofaan
added a commit
that referenced
this pull request
Jun 18, 2025
soxofaan
force-pushed
the
issue699-stac11-band-support
branch
from
79eae28 to
68c4b6b
Compare
soxofaan
added a commit
that referenced
this pull request
Jun 18, 2025
soxofaan
added a commit
that referenced
this pull request
Jun 18, 2025
soxofaan
force-pushed
the
issue699-stac11-band-support
branch
from
c9fc810 to
81d0d84
Compare
soxofaan
added a commit
that referenced
this pull request
Sep 9, 2025
soxofaan
added a commit
that referenced
this pull request
Sep 9, 2025
soxofaan
added a commit
that referenced
this pull request
Sep 9, 2025
soxofaan
added a commit
that referenced
this pull request
Sep 9, 2025
soxofaan
added a commit
that referenced
this pull request
Sep 9, 2025
soxofaan
added a commit
that referenced
this pull request
Sep 9, 2025
soxofaan
added a commit
that referenced
this pull request
Sep 9, 2025
soxofaan
added a commit
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #699, #692, #586